chore(map): reduce cost of culling doodads

wowserhq · Feb 2, 2024 · 7e0b863 · 7e0b863
1 parent 2ce8a37
commit 7e0b863
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/lib/map/DoodadManager.ts b/src/lib/map/DoodadManager.ts
@@ -42,7 +42,8 @@ class DoodadManager {
       areaGroup.visible = areaVisible;
 
       for (const doodad of areaGroup.children as Model[]) {
-        const doodadVisible = areaVisible && cullingFrustum.intersectsObject(doodad);
+        const doodadVisible =
+          areaVisible && cullingFrustum.intersectsSphere(doodad.boundingSphereWorld);
 
         if (doodadVisible) {
           doodad.show();

diff --git a/src/lib/model/Model.ts b/src/lib/model/Model.ts
@@ -13,6 +13,8 @@ class Model extends THREE.Object3D {
   #mesh: THREE.Mesh;
   #skinned: boolean;
 
+  #boundingSphereWorld = new THREE.Sphere();
+
   constructor(
     geometry: THREE.BufferGeometry,
     materials: THREE.Material[],
@@ -56,6 +58,10 @@ class Model extends THREE.Object3D {
     return this.#mesh.geometry.boundingSphere;
   }
 
+  get boundingSphereWorld() {
+    return this.#boundingSphereWorld;
+  }
+
   get skinned() {
     return this.#skinned;
   }
@@ -82,6 +88,12 @@ class Model extends THREE.Object3D {
     this.animation.resume();
   }
 
+  updateMatrixWorld(force?: boolean) {
+    super.updateMatrixWorld(force);
+
+    this.#boundingSphereWorld.copy(this.boundingSphere).applyMatrix4(this.matrixWorld);
+  }
+
   #onBeforeRender(
     renderer: THREE.WebGLRenderer,
     scene: THREE.Scene,