Add async traits, implementations and fuzzers #9
Conversation
…tation requirements
|
You can simply write a wrapper around a Analogous for producers as well, of course.
|
|
(There's little else for me to review, those wrappers would get around all that copypasted code that I'm now skipping over.) |
|
The pipe functions don't need separate error types for sync, nb, and local, nb. Those should all use the same type, unless I'm missing something. |
| /// | ||
| /// Must not be called after any function of this trait has returned an error, | ||
| /// nor after `close` was called. | ||
| fn consumer_slots( |
There was a problem hiding this comment.
Huh, why doesn't this require the explicit lifetime bound that local_nb::Consumer::consumer_slots needs?
There was a problem hiding this comment.
Something to do with the additional trait bounds maybe?
src/lib.rs
Outdated
| pub mod sync; | ||
| pub mod sync_to_local_nb; |
There was a problem hiding this comment.
I'm open to changing the location of this module. Could also be incorporated into the sync module.
There was a problem hiding this comment.
I'd place it in the local_nb module. I'd prefer keeping those three top-level mods and then putting any details inside them.
|
All looking good so far. |
|
@AljoschaMeyer Any changes or additions you'd like to see here before merging? I can do the |
|
Looks good. |
nb:Sendlocal_nb:!SendSyncToLocalNbConsumerandSyncToLocalNbProducerwrapperstructslocal_nbconsumer implementationsCursorIntoVecIntoVecFallibleInvariantInvariantNoopScramblelocal_nbproducer implementationsCursorInvariantInvariantNoopScramblelocal_nbfuzzerscursorsinvariantinvariant_noopscramble_consumerscramble_producer