Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create WorldIDIdentityManagerImplV2 to add support for deleteIdentities #126

Merged
merged 21 commits into from
Sep 7, 2023
Merged

create WorldIDIdentityManagerImplV2 to add support for deleteIdentities #126

merged 21 commits into from
Sep 7, 2023

Conversation

dcbuild3r
Copy link
Collaborator

@dcbuild3r dcbuild3r commented Aug 24, 2023 •
edited
Loading

Targets issue #120.

This change includes:

  1. Adding a lookup table for deletion verifiers
  2. Adding a method to delete identities
  3. Add tests for deletion logic
  4. Remove V1 methods pertaining to built-in state bridge logic

@dcbuild3r dcbuild3r self-assigned this Aug 24, 2023
@dcbuild3r dcbuild3r added the enhancement New feature or request label Aug 24, 2023
@dcbuild3r dcbuild3r linked an issue Aug 24, 2023 that may be closed by this pull request
Add deleteIdentities function #120
Closed
2 tasks
dcbuild3r and others added 11 commits August 24, 2023 21:23
@dcbuild3r
intermediary push
0857b12
@dcbuild3r
fix tests
45d97ba 
tests compile, however missing ImplV2 tests for init, uninit and deletionVerifier logic
@dcbuild3r
fix init tests
abc2da2
@dcbuild3r
fix uninit tests
d15e456
@dcbuild3r
add deletion tests
a889d2e 
missing two tests which require the real gnark circuit, pending
@dcbuild3r
add deletion circuit tests
8f40fc8 
failing atm
@dcbuild3r
add getters setters tests
7a75193
@kustosz
add asm keccak
cbdf914
@dcbuild3r
compilation fix
a6ab8c0 
tests are still broken
@kustosz
fix test
46ec55e
@dcbuild3r
fix deletion tests
bc4c9f4
@dcbuild3r dcbuild3r marked this pull request as ready for review September 7, 2023 10:20
@dcbuild3r dcbuild3r merged commit 68c9569 into main Sep 7, 2023
1 check passed
@dcbuild3r dcbuild3r deleted the dcbuild3r/add-delete-identities branch September 7, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xKitsune 0xKitsune 0xKitsune approved these changes

Assignees

@dcbuild3r dcbuild3r

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add deleteIdentities function
3 participants
@dcbuild3r @0xKitsune @kustosz