Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid casting to NSError in favor of WordPressApiError #779

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

Avoid casting to NSError in favor of WordPressApiError #779

wants to merge 4 commits into from

Commits on Apr 5, 2024

  1. Avoid casting to NSError in favor of WordPressApiError 

    See discussion at
#777 (comment)
with @crazytonyli
    @mokagio
    mokagio committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    80ac1e9 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Rename castToEndpointErrorWitCode to castedToEndpointErrorWitCode

    @mokagio
    mokagio committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    568d67f View commit details
    Browse the repository at this point in the history

  2. Restore returning error instead of cast endpointError 

    Thanks for the hint @crazytonyli.
See
https://github.com/wordpress-mobile/WordPressKit-iOS/pull/779/files#r1552634468
    @mokagio
    mokagio committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    9d5aa85 View commit details
    Browse the repository at this point in the history

  3. Use better API to set error key code in JetpackServiceRemote

    @mokagio
    mokagio committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    794f03f View commit details
    Browse the repository at this point in the history