Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment – Move code used only by Jetpack/WordPress to that codebase #737

Closed
wants to merge 9 commits into from

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Feb 23, 2024

@mokagio
Copy link
Contributor Author

mokagio commented Feb 23, 2024

Unit tests failed in CI with:

testMobilePluginRedirectedError() in WordPressOrgXMLRPCValidatorTests (3 times)

- Unexpected request: https://www.apple.com/xmlrpc.php (/opt/ci/builds/builder/automattic/wordpresskit-ios/WordPressKitTests/WordPressAPI/WordPressOrgXMLRPCValidatorTests.swift#EndingLineNumber=14&StartingLineNumber=14)

It's possible my changes resulted in that failure. I haven't investigated it yet, in the interest of moving forward with the experiment.

For what is worth, the test passes on my machine.

image

There is one failure in the screenshot, but it's a flaky test. Something that should be investigated, but unrelated to the CI failure.

@mokagio
Copy link
Contributor Author

mokagio commented Jun 5, 2024

Closing because it served its purpose and there's no need to keep it making noise in the open PRs list

@mokagio mokagio closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant