Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TCP connection issues (PoC) #23035

Closed
wants to merge 1 commit into from
Closed

Fix TCP connection issues (PoC) #23035

wants to merge 1 commit into from

Conversation

kean
Copy link
Contributor

@kean kean commented Apr 18, 2024

RCA: the app creates too many URLSession instances and fails to limit the number of concurrent TCP connections

Related WPKit PR: wordpress-mobile/WordPressKit-iOS#793
Discussion p1713456750263869-slack-C06UMJ84YB

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dangermattic
Copy link
Collaborator

dangermattic commented Apr 18, 2024

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@kean kean marked this pull request as ready for review April 18, 2024 17:11
@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23035-ae1ed3b
Version24.7
Bundle IDcom.jetpack.alpha
Commitae1ed3b
App Center Buildjetpack-installable-builds #8603
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23035-ae1ed3b
Version24.7
Bundle IDorg.wordpress.alpha
Commitae1ed3b
App Center BuildWPiOS - One-Offs #9559
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean changed the title Fix TCP connection issues Fix TCP connection issues (PoC) Apr 19, 2024
@kean kean closed this May 4, 2024
@jkmassel jkmassel deleted the fix/tcp-connection-issue branch July 26, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants