Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a copy-paste issue in the unit tests #22692

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Feb 23, 2024

Stumbled upon this one while working on #22690 . Apologies for missing it during code review.


Regression Notes

  1. Potential unintended areas of impact – N.A.
  2. What I did to test those areas of impact (or what existing automated tests I relied on) – N.A.
  3. What automated tests I added (or what prevented me from doing so) – N.A.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes. N.A.
  • I have considered adding accessibility improvements for my changes. N.A.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. N.A.

UI changes testing checklist: Not a UI PR.

@mokagio mokagio added this to the 24.4 milestone Feb 23, 2024
@mokagio mokagio added the Testing Unit and UI Tests and Tooling label Feb 23, 2024
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22692-b3a3cb3
Version24.3
Bundle IDorg.wordpress.alpha
Commitb3a3cb3
App Center BuildWPiOS - One-Offs #8943
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22692-b3a3cb3
Version24.3
Bundle IDcom.jetpack.alpha
Commitb3a3cb3
App Center Buildjetpack-installable-builds #7973
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@crazytonyli crazytonyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@mokagio mokagio merged commit 4335508 into trunk Feb 23, 2024
21 of 24 checks passed
@mokagio mokagio deleted the mokagio/fix-minor-copy-paste-issue branch February 23, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Unit and UI Tests and Tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants