[MVC구현 / 3단계] 로이(김덕우) 미션 제출합니다. #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go-Jaecheol
requested changes
Sep 26, 2023
Comment on lines
+19
to
+22
| return this.handlerAdapters.stream() | ||
| .filter(handlerAdapter -> handlerAdapter.isSupport(handler)) | ||
| .findFirst() | ||
| .orElseThrow(() -> new IllegalArgumentException("해당 handler를 찾을 수 없습니다.")); |
There was a problem hiding this comment.
지금 Controller가 제대로 동작하고 있는지 http://localhost:8080/login/view와 같은 url로 확인했을 때, 제대로 된 페이지 뷰가 나오지 않는 걸 확인했어요!
오늘 강의 초반에도 언급되었던 DispatcherServletInitializer의 패키지 위치 때문인 것 같아요!
|
안녕하세요 망고! 꼼꼼하게 챙기지 못했네요ㅠ 제가 놓친 부분 까지 살펴봐주셔서 감사합니다👍 말씀하신대로 DispatcherServletInitializer 패키지 위치가 문제였던 것 같습니다. 패키지 app으로 위치를 바꾸는 방식으로 수정해봤어요! 리뷰 감사했습니다. 명절 잘 보내세요!! |
Go-Jaecheol
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 망고!
미션 구현이 좀 늦었네요ㅠ
2단계에서 질문주신 내용에 제대로된 답변을 못드린 듯해서 부끄럽네요..
부족한 부분은 추후 좀 더 공부해보겠습니다.
시간 날 때 편하게 리뷰 주시면 감사하겠습니다!