[MVC 구현하기 - 3단계] 말랑(신동훈) 미션 제출합니다. #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junpakPark
requested changes
Sep 25, 2023
Comment on lines
+41
to
+42
| View view = modelAndView.getView(); | ||
| view.render(modelAndView.getModel(), request, response); |
There was a problem hiding this comment.
ModelAndView에 render 메서드를 구현한 후에 거기서 실행하는 방법도 있을 것 같은데
지금처럼 구현하신 이유가 궁금합니다 ㅎㅎ
혹시 View를 렌더링한다는 의미를 더 명확하게 보여주기 위함인가요?
There was a problem hiding this comment.
저도 이 부분을 조금 고민하긴 했는데
이렇게 구현하는게 사용하는 입장에서 좀 더 사용하기 편리하지 않을까..? 하는 생각이 들었습니다
Comment on lines
+19
to
+24
| String value; | ||
| if (model.size() == 1) { | ||
| value = String.valueOf(model.values().toArray()[0]); | ||
| } else { | ||
| value = objectMapper.writeValueAsString(model); | ||
| } |
There was a problem hiding this comment.
메서드 분리 후 String 값 리턴하게 하는 건 어떨까용? ㅎㅎ
There was a problem hiding this comment.
간단한 메서드라 굳이 분리하지 않아도 읽는데 어려움이 없다고 판단했는데, 불편하시려나요?
허허 뭣도 모르고 한 소리였습니다..^^ |
junpakPark
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 갓준팍!
3단계 리뷰 잘 부탁드립니다!
DispatcherServlet의 패키지는 mvc로 옮겼지만, DispatcherServletInitializer은 app에 그대로 위치시켜뒀습니다.
DispatcherServletInitializer 클래스 역시 옮기면 좋겟지만, 그렇게 되면 코드의 대공사가 일어나야 할 것 같아서 우선 좀 참았습니다!
클래스 구성도 역시 힌트를 참고해 보았는데 현재 구조와 그렇게까지 차이나지는 않아서 따로 변경하지 않았습니다.
(ex: HandlerMappingRegistry를 만드는 등..)
피드백 주시면 반영하겠습니다 :)