[MVC 미션 1단계] 오리(오현서) 미션 제출합니다. #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miseongk
approved these changes
Sep 14, 2023
Comment on lines
+41
to
+44
| Set<Class<?>> clazz = getClazzByAnnotation(packagePath, Controller.class); | ||
| for (Class<?> aClass : clazz) { | ||
| List<Method> methods = getMethodsByAnnotation(aClass, RequestMapping.class); | ||
| Object instance = getInstance(aClass); |
| } | ||
| } | ||
|
|
||
| private <T extends Annotation> Set<Class<?>> getClazzByAnnotation(Object packagePath, Class<T> annotationClass) { |
There was a problem hiding this comment.
메서드명을 getClassByAnnotation이라고 해도 좋을 것 같아요!
Comment on lines
+74
to
+79
| RequestMapping requestMapping = method.getAnnotation(RequestMapping.class); | ||
| for (RequestMethod requestMethod : requestMapping.method()) { | ||
| HandlerKey handlerKey = new HandlerKey(requestMapping.value(), requestMethod); | ||
| handlerExecutions.put(handlerKey, handlerExecution); | ||
| } | ||
| } |
There was a problem hiding this comment.
RequestMapping 어노테이션을 보면 method 디폴트가 빈 배열이여서 만약 RequestMapping을 사용하는 개발자가 실수로 method를 지정해주지 않는다면 해당 메서드는 등록되지 않겠네요!
이런 경우 get할 때 null을 반환하네요. 이에 대한 예외 처리도 해주면 좋을 것 같은데 어떻게 생각하시나요??
There was a problem hiding this comment.
아! 추가적으로 위와 같은 맥락으로 getHandler()를 호출 했을 때 해당하는 핸들러가 없을 때 null을 반환하기 때문에 외부에서 handlerExecution.handle(request, response); 을 할 때 NPE가 뜨게 되는데 null을 반환하는게 좋을까요?
There was a problem hiding this comment.
말씀해주신 부분을 놓치고 있었네요!! 다음 단계 들어가면서 관련 로직을 추가해보겠습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 밀리 잘부탁드립니다.
1단계는 테스트 하기에도 패키지에 의존하기 때문에 어렵네요..
학습 테스트는 별도 로컬 브랜치에서 해서 커밋이 얼마 없습니다.
구구 커밋 빼고 보기