[MVC 구현하기 1단계] 로지(윤가영) 미션 제출합니다 #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This2sho
approved these changes
Sep 14, 2023
| private final Map<HandlerKey, HandlerExecution> handlerExecutions; | ||
|
|
||
| public AnnotationHandlerMapping(final Object... basePackage) { | ||
| this.basePackage = basePackage; | ||
| this.basePackages = basePackage; |
| final var controllers = Arrays.stream(basePackages) | ||
| .flatMap(basePackage -> getControllerFrom(basePackage).stream()) | ||
| .map(this::newInstance) | ||
| .collect(Collectors.toList()); |
This2sho
reviewed
Sep 14, 2023
| public HandlerExecution(final Object instance, final Method handler) { | ||
| this.instance = instance; | ||
| this.handler = handler; | ||
| } |
There was a problem hiding this comment.
별건 아니지만 Method 타입만 받고 다음과 같은 방법으로 Instance를 만드는 방법도 있을 거 같습니다!
handler.getDeclaringClass().getConstructor().newInstance();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 호이 :D
mvc 미션 잘 부탁드립니다!!