[MVC 구현하기 - 1단계] 글렌(전석진) 미션 제출합니다. #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingpyo
approved these changes
Sep 14, 2023
| log.info("Initialized AnnotationHandlerMapping!"); | ||
| handlerExecutions.keySet() | ||
| .forEach(handlerKey -> log.info("Handler Key: {}", handlerKey)); |
Comment on lines
+63
to
+71
| Method[] methods = clazz.getDeclaredMethods(); | ||
| return Arrays.stream(methods) | ||
| .filter(method -> method.isAnnotationPresent(RequestMapping.class)) | ||
| .collect(toSet()); | ||
| } | ||
|
|
||
| private List<HandlerKey> getHandlerKeys(RequestMapping annotation) { | ||
| String url = annotation.value(); | ||
| RequestMethod[] httpMethods = annotation.method(); |
There was a problem hiding this comment.
재사용하지 않은 부분은 변수추출을 하지않고 바로 사용해보는거는 어떨까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 비버!
레벨3때 이후로 간만이네요 😁
Step1 구현하고 미션 제출합니다.
AnnotationHandlerMapping의 흐름은 다음과 같습니다.Reflections객체를 생성@Controller어노테이션이 붙은 클래스를 찾음initializeHandler()메소드를 통해 Class 타입의 객체를 인스턴스화@RequestMapping어노테이션이 붙은 메소드를 찾음@RequestMapping속성에 있는 url과 httpMethod로HandlerKey객체 생성handlerExecution객체 생성HandlerKey객체를 key,HandlerExecution객체를 value로 Map에 put테스트 코드를 추가로 작성하려고 했는데, 기존에 있는
AnnotationHandlerMappingTest에 있는 테스트로 충분한 것 같아 테스트 코드는 작성하지 않았습니다!리뷰 기다리겠습니다!
감사합니다
리뷰 범위