mvc step1 주드 미션 제출합니다 #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed.
|
rawfishthelgh
approved these changes
Sep 13, 2023
| Method[] methods = controller.getMethods(); | ||
| Arrays.stream(methods) | ||
| .filter(method -> method.isAnnotationPresent(RequestMapping.class)) | ||
| .forEach(this::putHandlers); |
There was a problem hiding this comment.
A
stream의 forEach 연산은 가급적 출력용으로만 사용하는게 좋을 것 같다는 생각이 드는데, 어떻게 생각하시나요?
현재는 stream 외부 변수에 영향을 주는 로직이 forEach에 존재하고 있네요
참고
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 새로운 리뷰어 하마드
미션 요구사항이 어디까지인지 잘 모르겠어서 @RequestMapping만 구현해서 제출합니다
구구의 커밋까지 포함돼서 커밋범위 링크 드립니다
여기