[MVC 구현하기 - 1단계] 비버(전인표) 미션 제출합니다. #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shb03323
reviewed
Sep 14, 2023
|
|
||
| private void registerMethod(final Class<?> clazz, final Method method) { | ||
| RequestMapping requestMapping = method.getAnnotation(RequestMapping.class); | ||
| final String value = requestMapping.value(); |
There was a problem hiding this comment.
request mapping 어노테이션에 value로 정의되어 있으니 value라는 변수명으로 uri를 저장해도 괜찮다고 생각합니다.
주관적인 생각입니다! 취향 차이라 생각이 다르시다면 굳이 수정하지 않으셔도 괜찮습니당.
HandlerKey의 생성자 매개변수로 들어갈 변수이기 때문에 value보다 HandlerKey 필드에 맞는 uri가 어떨까 해요.
현재 registerMethod()의 역할 중 하나는 HandlerKey 를 생성하는 것인데요. 이때 생성자의 인자를 받기 위해 value를 만들었잖아요. 그러면 registerMethod()에서 value 변수가 정의된 순간부터 value는 HandlerKey를 만들기 위한 부품이라고 생각해요. 이전의 "RequestMapping의 필드" 역할을 쭈욱 이어받는 것이 아니라용. 그래서 uri가 역할에 더 적합한 변수명이 아닐까 생각했습니다.
shb03323
reviewed
Sep 14, 2023
| } | ||
|
|
||
| public Object getHandler(final HttpServletRequest request) { | ||
| return null; | ||
| final HandlerKey handlerKey = new HandlerKey(request.getRequestURI(), RequestMethod.valueOf(request.getMethod())); |
shb03323
reviewed
Sep 14, 2023
Comment on lines
+54
to
+58
| return handlerExecutions.keySet().stream() | ||
| .filter(handlerKey::equals) | ||
| .map(handlerExecutions::get) | ||
| .findFirst() | ||
| .orElseThrow(() -> new IllegalArgumentException("존재하지 않은 요청입니다.")); |
shb03323
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 디투!!
리뷰 잘 부탁드립니다! 😄