Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kakao 사용자 정보 받아오는 response 변경 #772

Merged
merged 5 commits into from
Jan 4, 2024

Conversation

mcodnjs
Copy link
Collaborator

@mcodnjs mcodnjs commented Jan 2, 2024

📄 Summary

#771

사용자 정보 받아오는 response 변경하였습니다.
그리고 이미지 url의 경우 https로 받아오도록 쿼리 파라미터 추가했는데 적용이 안되네요 ㅇㅅㅇ

image

🙋🏻 More

@mcodnjs mcodnjs self-assigned this Jan 2, 2024
@mcodnjs mcodnjs linked an issue Jan 2, 2024 that may be closed by this pull request
2 tasks
Copy link

github-actions bot commented Jan 2, 2024

📝 Jacoco Test Coverage

Total Project Coverage 77.89%
File Coverage [11.61%]
KakaoOauthProvider.java 13.53%
KakaoUserInfo.java 0%

Copy link
Member

@jjongwa jjongwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

멋지네요 approve 하겠습니다.

Copy link
Member

@dladncks1217 dladncks1217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@mcodnjs mcodnjs merged commit c7f3a04 into develop Jan 4, 2024
1 check passed
hgo641 pushed a commit that referenced this pull request Apr 23, 2024
* refactor: secure resources 쿼리 파라미터 설정

* refactor: 카카오 사용자 정보 가져오기 응답값 수정

* refactor: KakaoProfile 내부 클래스 추가

* refactor: 쿼리 파라미터 값 타입 변경

* refactor: 쿼리 파라미터 값 타입 변경
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

카카오 사용자 정보 가져오기 API 수정
3 participants