Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/#720 dependency #722

Merged
merged 5 commits into from
Oct 19, 2023
Merged

Refactor/#720 dependency #722

merged 5 commits into from
Oct 19, 2023

Conversation

waterricecake
Copy link
Collaborator

📄 Summary

#720

Community와 Trip의 의존성을 분리하였습니다.
EventListener를 통해 TripService에서
PublishedRepository가 필요한 로직들을 분리하였습니다.
Test의 경우 TestConfiguration으로 JpaDataTest가 빈등록을 못하던
Event를 넣어서 해결하였습니다.

before :

스크린샷 2023-10-18 오후 11 30 27

after :

스크린샷 2023-10-18 오후 11 25 55

🙋🏻 More

@waterricecake waterricecake self-assigned this Oct 18, 2023
@waterricecake waterricecake linked an issue Oct 18, 2023 that may be closed by this pull request
패키지 간 순환 의존성 제거를 위한 필드 간접 참조 변경 #720
Closed
2 tasks
@waterricecake waterricecake removed a link to an issue Oct 18, 2023
패키지 간 순환 의존성 제거를 위한 필드 간접 참조 변경 #720
Closed
2 tasks
@github-actions
Copy link

github-actions bot commented Oct 18, 2023 •
edited
Loading

📝 Jacoco Test Coverage

Total Project Coverage 79.88% ❌
File Coverage [78.98%]
PublishEvent.java 100% 🍏
PublishDeleteEvent.java 100% 🍏
PublishEventListener.java 100% 🍏
TripService.java 97.67% 🍏
CommunityService.java 81.07% 🍏
PublishedTrip.java 73.91% ❌
LoginService.java 26.54% ❌

LJW25
LJW25 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@LJW25 LJW25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해내셨군요 달리
저도 집와서 계속 이 브랜치 보면서 이리저리 고쳐보고 있었는데.. 달리가 해내셔서 다행입니다..ㅎ
수고하셨습니다.

backend/src/test/java/hanglog/integration/service/CommunityServiceIntegrationTest.java Outdated
@@ -41,6 +43,7 @@ class CommunityServiceIntegrationTest extends ServiceIntegrationTest {
@Autowired
private CommunityService communityService;


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

공백 잘못들어간것같아요!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aa740dc

hgo641
hgo641 approved these changes Oct 19, 2023
View reviewed changes
backend/src/main/java/hanglog/community/service/CommunityService.java Outdated
Comment on lines 65 to 66
final TripCityElements tripCityElements = new TripCityElements(
tripCityRepository.findTripIdAndCitiesByTripIds(tripIds));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

별건아닌데 컨벤션 이거 아니었던듯!?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aca306b

@LJW25 LJW25 linked an issue Oct 19, 2023 that may be closed by this pull request
패키지 간 순환 의존성 제거를 위한 필드 간접 참조 변경 #720
Closed
2 tasks
@waterricecake waterricecake merged commit 4fb352a into develop Oct 19, 2023
1 check passed
jjongwa pushed a commit that referenced this pull request Oct 19, 2023
@waterricecake @jjongwa
Refactor/#720 dependency (#722)
477239a 
* refactor: publishedTrip tripId 분리

* refactor: Event로 publish update 로직 분리

* refactor: Event로 publish delete 로직 분리

* style: 코드 컨벤션 적용

* style: 코드 컨벤션 적용
@waterricecake waterricecake deleted the refactor/#720-dependency branch October 23, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LJW25 LJW25 LJW25 approved these changes

@hgo641 hgo641 hgo641 approved these changes

@mcodnjs mcodnjs Awaiting requested review from mcodnjs

@jjongwa jjongwa Awaiting requested review from jjongwa

Assignees

@waterricecake waterricecake

Labels
BE 🔨 Refactor
Projects
2023-hang-log
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

패키지 간 순환 의존성 제거를 위한 필드 간접 참조 변경
3 participants
@waterricecake @LJW25 @hgo641