대표이미지 수정버그, 아이템 이미지 등록삭제시 생기는 버그 수정 #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dahyeeee
force-pushed
the
fix/#694-image
branch
from
6778f41
to
b5cae07
Compare
Dahyeeee
force-pushed
the
fix/#694-image
branch
from
c5161f4
to
7d4856a
Compare
dladncks1217
approved these changes
Oct 18, 2023
jjongwa
pushed a commit
that referenced
this pull request
Oct 19, 2023
* refactor:여러이미지업로드 로직 함수분리, 변수명변경 * fix: 대표사진 업로드 버그 수정(맥시멈 사진갯수지정) * fix: 배열 멱등성 지켜서 버그 방지 * refactor:이미지url 변수명 변경 * refactor: 모바일 모달창 문구보이게 margin추가
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
imageName이랑 imageUrl이랑 헷갈려서 일단 변수명부터 분리했구용
로직도 너무 복잡해서 함수로 분리햇습니다.
이미지처리 로직이 3개라 너무 복잡하다~~ㅎㅎㅎㅎ
🙋🏻 More
close #694 #713