카테고리 목록 조회 API 구현 #158
Merged
카테고리 목록 조회 API 구현 #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 Jacoco Test Coverage
|
LJW25
approved these changes
Jul 27, 2023
Comment on lines
+179
to
+180
| ==== 응답 | ||
| include::{snippets}/category-controller-test/get-expense-categories/http-response.adoc[] |
| public List<CategoryResponse> getExpenseCategories() { | ||
| final List<Category> expenseCategories = categoryRepository.findExpenseCategory(); | ||
| return expenseCategories.stream() | ||
| .map(category -> new CategoryResponse(category.getId(), category.getKorName(), category.getEngName())) |
There was a problem hiding this comment.
Category처럼 CategoryResponse도 EngName이 먼저 오게 통일하는거 어떤가요?
There was a problem hiding this comment.
아니 잘못된 생각이었음. Response에서 EngName 빼주세요. 프론트에서 영어이름 노필요
Comment on lines
56
to
68
| responseFields( | ||
| fieldWithPath("[].id") | ||
| .type(JsonFieldType.NUMBER) | ||
| .description("카테고리 ID") | ||
| .attributes(field("constraint", "양의 정수")), | ||
| fieldWithPath("[].engName") | ||
| .type(JsonFieldType.STRING) | ||
| .description("카테고리 영문명") | ||
| .attributes(field("constraint", "50자 이하의 문자열")), | ||
| fieldWithPath("[].korName") | ||
| .type(JsonFieldType.STRING) | ||
| .description("카테고리 한글명") | ||
| .attributes(field("constraint", "50자 이하의 문자열")) |
There was a problem hiding this comment.
RestDocs 💯
adocs에만 추가해 주시면 완벽할것같습니다
hgo641
approved these changes
Jul 27, 2023
|
|
||
| public interface CategoryRepository extends JpaRepository<Category, Long> { | ||
|
|
||
| @Query("SELECT c FROM Category c WHERE MOD(c.id, 100) = 0") |
waterricecake
approved these changes
Jul 27, 2023
Comment on lines
+6
to
+15
| public class CategoryFixture { | ||
|
|
||
| public static final List<Category> EXPENSE_CATEGORIES = List.of( | ||
| new Category(100L, "food", "음식"), | ||
| new Category(200L, "culture", "문화"), | ||
| new Category(300L, "shopping", "쇼핑"), | ||
| new Category(400L, "accommodation", "숙박"), | ||
| new Category(500L, "transportation", "교통"), | ||
| new Category(600L, "etc", "기타") | ||
| ); |
There was a problem hiding this comment.
경비 조회 기능 하면서 categoryFixture 추가했는데 둘중 하나로 선택해야 할 것 같네요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
🙋🏻 More