Skip to content

Commit

Permalink
refactor: pageSkeleton 제거
Browse files Browse the repository at this point in the history
  • Loading branch information
LJW25 committed Feb 10, 2024
1 parent 294ba78 commit ebb0bb3
Show file tree
Hide file tree
Showing 11 changed files with 31 additions and 175 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,7 @@ export const useAddAdminMemberForm = ({ onSuccess, onError }: useAddAdminMemberF

addAdminMemberMutaion.mutate(
{
username: adminMemberInformation.username,
adminType: adminMemberInformation.adminType,
password: adminMemberInformation.password,
...adminMemberInformation,
},
{ onSuccess, onError }
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,8 @@ export const useUpdatePasswordForm = (

updatePasswordMutaion.mutate(
{
adminMemberId: adminMemberId,
currentPassword: adminMemberInformation.currentPassword,
newPassword: adminMemberInformation.newPassword,
adminMemberId,
...adminMemberInformation,
},
{ onSuccess, onError }
);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import { Button, Flex, Heading, useOverlay } from 'hang-log-design-system';
import { useCallback, useEffect, useState } from 'react';
import { Suspense, useCallback, useEffect, useState } from 'react';

import AdminMemberTableSkeleton from '@/components/adminMember/AdminMemberTable/AdminMemberTableSkeleton';

import AdminMemberAddModal from '@components/adminMember/AdminMemberAddModal/AdminMemberAddModal';
import AdminMemberTable from '@components/adminMember/AdminMemberTable/AdminMemberTable';
Expand Down Expand Up @@ -53,7 +55,9 @@ const AdminMemberPage = () => {
추가하기
</Button>
<section css={tableStyling}>
<AdminMemberTable adminMembers={currentPageData} />
<Suspense fallback={<AdminMemberTableSkeleton length={TABLE_ROW_LENGTH} />}>
<AdminMemberTable adminMembers={currentPageData} />
</Suspense>
</section>
<PageNavigation
pages={pageIndexDatas}
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import { Button, Flex, Heading, useOverlay } from 'hang-log-design-system';
import { useCallback, useEffect, useState } from 'react';
import { Suspense, useCallback, useEffect, useState } from 'react';

import CategoryTableSkeleton from '@/components/category/CategoryTable/CategoryTableSkeleton';

import CategoryAddModal from '@components/category/CategoryAddModal/CategoryAddModal';
import CategoryTable from '@components/category/CategoryTable/CategoryTable';
Expand Down Expand Up @@ -53,7 +55,9 @@ const CategoryPage = () => {
추가하기
</Button>
<section css={tableStyling}>
<CategoryTable categories={currentPageData} />
<Suspense fallback={<CategoryTableSkeleton length={TABLE_ROW_LENGTH} />}>
<CategoryTable categories={currentPageData} />
</Suspense>
</section>
<PageNavigation
pages={pageIndexDatas}
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import { Button, Flex, Heading, useOverlay } from 'hang-log-design-system';
import { useCallback, useEffect, useState } from 'react';
import { Suspense, useCallback, useEffect, useState } from 'react';

import CityTableSkeleton from '@/components/city/CityTable/CityTableSkeleton';

import CityAddModal from '@components/city/CityAddModal/CityAddModal';
import CityTable from '@components/city/CityTable/CityTable';
Expand Down Expand Up @@ -45,7 +47,9 @@ const CityPage = () => {
추가하기
</Button>
<section css={tableStyling}>
<CityTable cities={currentPageData} />
<Suspense fallback={<CityTableSkeleton length={TABLE_ROW_LENGTH} />}>
<CityTable cities={currentPageData} />
</Suspense>
</section>
<PageNavigation
pages={pageIndexDatas}
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import { Button, Flex, Heading, useOverlay } from 'hang-log-design-system';
import { useCallback, useEffect, useState } from 'react';
import { Suspense, useCallback, useEffect, useState } from 'react';

import CurrencyTableSkeleton from '@/components/currency/CurrencyTable/CurrencyTableSkeleton';

import PageNavigation from '@components/common/PageNavigation/PageNavigation';
import SidebarNavigation from '@components/common/SidebarNavigation/SidebarNavigation';
Expand Down Expand Up @@ -50,7 +52,9 @@ const CurrencyPage = () => {
추가하기
</Button>
<section css={tableStyling}>
<CurrencyTable currencies={currencyListData.currencies} />
<Suspense fallback={<CurrencyTableSkeleton length={TABLE_ROW_LENGTH} />}>
<CurrencyTable currencies={currencyListData.currencies} />
</Suspense>
</section>
<PageNavigation
pages={pageIndexDatas}
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,9 @@ import App from '@/App';

import AdminMainPage from '@pages/AdminMainPage/AdminMainPage';
import AdminMemberPage from '@pages/AdminMemberPage/AdminMemberPage';
import AdminMemberPageSkeleton from '@pages/AdminMemberPage/AdminMemberPageSkeleton';
import CategoryPage from '@pages/CategoryPage/CategoryPage';
import CategoryPageSkeleton from '@pages/CategoryPage/CategoryPageSkeleton';
import CityPage from '@pages/CityPage/CityPage';
import CityPageSkeleton from '@pages/CityPage/CityPageSkeleton';
import CurrencyPage from '@pages/CurrencyPage/CurrencyPage';
import CurrencyPageSkeleton from '@pages/CurrencyPage/CurrencyPageSkeleton';
import NotFoundPage from '@pages/NotFoundPage/NotFoundPage';

import { PATH } from '@constants/path';
Expand All @@ -37,31 +33,31 @@ const router = createBrowserRouter([
{
path: PATH.ADMIN_MEMBER,
element: (
<Suspense fallback={<AdminMemberPageSkeleton />}>
<Suspense>
<AdminMemberPage />
</Suspense>
),
},
{
path: PATH.CITY,
element: (
<Suspense fallback={<CityPageSkeleton />}>
<Suspense>
<CityPage />
</Suspense>
),
},
{
path: PATH.CATEGORY,
element: (
<Suspense fallback={<CategoryPageSkeleton />}>
<Suspense>
<CategoryPage />
</Suspense>
),
},
{
path: PATH.CURRENCY,
element: (
<Suspense fallback={<CurrencyPageSkeleton />}>
<Suspense>
<CurrencyPage />
</Suspense>
),
Expand Down

0 comments on commit ebb0bb3

Please sign in to comment.