Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Manual Connect button to server side endpoint (3821) #2769

Draft
wants to merge 20 commits into
base: trunk
Choose a base branch
from

Conversation

stracker-phil
Copy link
Collaborator

@stracker-phil stracker-phil commented Nov 6, 2024

Description

Refactored and improved UI for the Manual Connect button on the first onboarding screen

Most important changes:

  • Move async code to "actions.js"
  • Integrate the "Advanced Options" into the new UI (without a mockup)
  • Form validation (show error when ID or secret is empty)
  • Show a spinner and lock the form during the async request
  • Display server response
  • Some small UX improvements, like making the labels next to the on-off toggles clickable

@stracker-phil stracker-phil force-pushed the PCP-3821-link-manual-connect-button-to-server-side-endpoint branch from 92cf3b4 to a914349 Compare November 7, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant