Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Global Product Identifier] Barcode Scanner Search #14334

Merged
merged 12 commits into from
Nov 7, 2024

Conversation

toupper
Copy link
Contributor

@toupper toupper commented Nov 6, 2024

Closes: #14332

Description

With this PR we add search by global unique identifier on top of SKU search after scanning a barcode (orders, Inventory). The logic is as follows:

  • Scan a code (QR or barcode)
  • Search by SKU
  • If nothing is returned or fails, search by global unique identifier.

Steps to reproduce

  1. Go to Products
  2. Tap on a product
  3. Tap on Inventory
  4. Tap on the barcode button besides the GTIN field. Scan a barcode, and save the product.
  5. Go to Orders
  6. Scan that same barcode.
  7. It should open the Create Order view with the above product added to the order.

Testing information

I also verified these cases:

  • I verified that the scanning barcode that contains an SKU number keeps working fine.
  • When the scanned code doesn't match either SKU or global unique identifier, we show an error message: "Product with Identifier <identifier> not found."
  • When the product is not purchasable, we show the message: Product with Identifier is not purchasable."

Screenshots

ScreenRecording_11-07-2024.13-45-23_1.MP4

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • [ X] Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@toupper toupper marked this pull request as draft November 6, 2024 16:14
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 6, 2024

1 Warning
⚠️ This PR is assigned to the milestone 21.1. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 6, 2024

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14334-0e33d52
Version20.9
Bundle IDcom.automattic.alpha.woocommerce
Commit0e33d52
App Center BuildWooCommerce - Prototype Builds #11480
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Base automatically changed from issue/14258-gtin-validation-right-placement to trunk November 7, 2024 09:27
@toupper toupper added type: task An internally driven task. feature: add/edit products Related to adding or editing products. labels Nov 7, 2024
@toupper toupper added this to the 21.1 milestone Nov 7, 2024
@toupper toupper marked this pull request as ready for review November 7, 2024 14:35
@toupper toupper merged commit 8fcb5d9 into trunk Nov 7, 2024
25 checks passed
@toupper toupper deleted the issue/14332-gtin-barcode-scanner-search branch November 7, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: add/edit products Related to adding or editing products. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add value in Barcode Scanner Search
3 participants