Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Custom Fields] Differentiate between raw JSON values and String values that contain valid JSON #14292

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

[Custom Fields] Differentiate between raw JSON values and String values that contain valid JSON #14292

wants to merge 5 commits into from

Commits on Nov 1, 2024

  1. Introduce logic to differentiate different types of the metadata value

    @hichamboushaba
    hichamboushaba committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    dfce9f2 View commit details
    Browse the repository at this point in the history

  2. Improve logic of parsing MetaData

    @hichamboushaba
    hichamboushaba committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    10c5fdc View commit details
    Browse the repository at this point in the history

  3. Fix unit tests

    @hichamboushaba
    hichamboushaba committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    e1f3277 View commit details
    Browse the repository at this point in the history

  4. Update custom fields to allow editing string wrapped JSON values

    @hichamboushaba
    hichamboushaba committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    4c429f1 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. Updates to ensure MetaData is encoded correctly in all cases 

    Also ensures we can't bypass the validation by instantiating the enum case directly.
    @hichamboushaba
    hichamboushaba committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    4f82a10 View commit details
    Browse the repository at this point in the history