Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do Not Merge] POS MVSU experiment #14291

Draft
wants to merge 4 commits into
base: experiment/pos-aggregate-model-with-multiple-items
Choose a base branch
from

Conversation

joshheald
Copy link
Contributor

Description

This is an experiment moving the ItemList to an MVSU approach.

If you go through the commits, you can see a reverted commit which experiments with making the itemlist state wholly the responsibility of the ItemListView, which would be great but doesn't work because of the way we handle the empty/error/initialLoading states on the parent DashboardView.

I don't think that's insurmountable, but didn't want to burn too much time on it for a POC.

Unfortunately it doesn’t quite work to bind upwards for the dashboard view to show fullscreen stuff instead of the item list.

Fundamentally, if the itemlist isn’t showing, it’s state isn’t considered any more.
@joshheald joshheald added type: task An internally driven task. status: do not merge Dependent on another PR, ready for review but not ready for merge. labels Nov 1, 2024
@dangermattic
Copy link
Collaborator

2 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14291-2013bd9
Version20.9
Bundle IDcom.automattic.alpha.woocommerce
Commit2013bd9
App Center BuildWooCommerce - Prototype Builds #11418
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: do not merge Dependent on another PR, ready for review but not ready for merge. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants