Access MainTabBarController through an abstraction #14062
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A refactoring to avoid accessing
MainTabBarController
directly or throughstatic
methods.To support a sidebar on iPad, we will likely need to create a new entity that encompasses both tab bar and split view functionality. Defining a clear public interface allows us to ensure that no functionality would be missed.
Testing information
This PR doesn't change any functionality. Only defines a protocol and accesses
MainTabBarController
through a shared entity rather than through a static method. However, I tested navigation through deep links, home actions, and generally within the app.Screenshots
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: