-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orders: Show trash option in order status filter list #13974
base: trunk
Are you sure you want to change the base?
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.
|
@hichamboushaba This works well for me. LMK what you think of the solution. |
Thanks @itsmeichigo for the ping, I tested the feature on my iPhone, and I have some remarks:
RPReplay_Final1726651038.mov
WDYT about these issues @itsmeichigo, are they blockers? For Android, if we decide to still follow this approach, I was planning on finding a way to avoid caching the trashed orders and always fetch them from network, which should fix |
One additional issue with the current implementation, but it's a point that can be fixed, we need to offer a way to restore the order, requiring the user to change the status manually to restore the order is not user-friendly, and also it doesn't allow the user to restore the old status, instead, we should offer a |
@hichamboushaba I responded in an internal thread: p1726800244113699-slack-C03L1NF1EA3. |
Version |
Version |
Version |
Version |
Closes: #13973
Description
This PR adds the option to see orders in trash as per feature request from users.
Currently, we're fetching order statuses from
wc/v3/reports/totals/orders
. This endpoint returns all statuses of orders in a store, but doesn't include the trash status.This PR adds the
trash
option manually to the order status filter list of the order list and last orders dashboard card. Orders with selected statuses including trash should be fetched as before from thewc/v3/orders
endpoint.Steps to reproduce
Testing information
Tested on simulator iPhone 15 Pro iOS 17.4:
Screenshots
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: