Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS] Change a default sorting of POS products to "menu_order" #13924

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

staskus
Copy link
Collaborator

@staskus staskus commented Sep 11, 2024

Context: p1726048025972449-slack-C070SJRA8DP

Description

Change a default sorting of POS products to "menu_order" to reflect the sorting set on wp-admin, WooCommerce -> Products -> Sorting.

Steps to reproduce

  1. Set the product order on wp-admin, WooCommerce -> Products -> Sorting
  2. Open POS
  3. Notice product order
  4. Change the product order on wp-admin, WooCommerce -> Products -> Sorting
  5. Pull to refresh
  6. Confirm the order has changed

Testing information

I didn't perform additional testing beyond the main flow.

Screenshots

menu_order.sorting.mov

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 11, 2024

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr13924-d4db9f1
Version20.3
Bundle IDcom.automattic.alpha.woocommerce
Commitd4db9f1
App Center BuildWooCommerce - Prototype Builds #10804
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants