This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Deactivate nightly builds #12137
Merged
Deactivate nightly builds #12137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your interest in contributing to WooCommerce! WooCommerce Blocks has been merged into the WooCommerce Monorepo. From now on, please open any issues or pull requests in the woocommerce/woocommerce repository. |
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.61 MB ℹ️ View Unchanged
|
nielslange
added
the
skip-changelog
nielslange
requested review from
a team,
tarunvijwani,
nefeline and
wavvves
and removed request for
a team and
tarunvijwani
wavvves
approved these changes
Dec 26, 2023
|
Thanks for reviewing this adjustment, @wavvves. 🙌 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes woocommerce/woocommerce#43070
Why
Currently, we're still generating nightly builds, each night at 12:01 AM, despite that the WooCommerce Blocks repo has been merged into the Woo core monorepo. This is resource-inefficient and creates unnecessary noise in https://a8c.slack.com/archives/C02UBB1EPEF.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Important
Due to the natuer of this change, we should merge this PR and then wait for 24h to see the change. No new nightly builds should occur via https://github.com/woocommerce/woocommerce-blocks/releases/tag/nightly.
Screenshots or screencast
n/a
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog
n/a