This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Remove placeholder image rendering and delegate it to Core's get_image function #12098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmanijak
added
type: bug
woocommercebot
requested review from
a team and
nefeline
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.61 MB ℹ️ View Unchanged
|
danieldudzic
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Good job :) Tested - this works correctly!
One minor consideration (not seeing it as a blocker).
It seems like there was a discussion and some intentionality behind setting alt to '' for the placeholder.
It seems that the core placeholder sets the alt to the name of the Product. It doesn't seem like a big deal to me, but perhaps it would make sense to create an Issue or a PR in Woo core to remove the alt, if that's the preferred option.
|
@danieldudzic, thanks for taking care of that PR! 🙌 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove the
wc_placeholder_imginvocation and keep theget_imagefunction call below.Fixes #12078
Why
wc_placeholder_imgwas called inProductImageblock if there was no product image. But that breaks some extensibility aswoocommerce_product_get_imagehook is not fired. We can simply callget_imagewhich internally handles the logic if there's no image (here) and in addition apply the filters.Context:
ifis unnecessary and we can delegate that logic to Core's function$placeholderistrueby defaultTesting Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Case 1: Rendering images
Case 2: Applying filter
functions.phpScreenshots or screencast
woocommerce_product_get_imagehook|
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog