This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Products By Attribute: E2E tests - skip test #12085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigitux
added
block: filter by attribute
woocommercebot
requested review from
a team and
Aljullu
and removed request for
a team
gigitux
added
the
skip-changelog
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.61 MB ℹ️ View Unchanged
|
nielslange
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Thanks for working on this, @gigitux. The change looks good, and all tests passed successfully. Let's ⛴️ this change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We decided to skip this E2E test because it is too very flaky. Also, the same test for other filter blocks is already disabled.
Also, we are improving the Filters block, and we already planned to add/improve the current E2E tests suite about filter blocks: woocommerce/woocommerce#42255
cc @roykho @dinhtungdu @samueljseay for awareness.
(feel free to merge the PR if you agree with the change)
Why
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog