This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix casting error on Utils::wp_version_compare #11802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alefesouza
added
the
skip-changelog
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.61 MB ℹ️ View Unchanged
|
hsingyuc
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
@alefesouza Thank you for working on this! I tested with a patch version and the existing code looks like it's not set up to match patches. Since that seems expected, this PR LGTM.
senadir
requested review from
a team,
tarunvijwani and
tarhi-saad
and removed request for
a team and
tarunvijwani
tarhi-saad
suggested changes
Dec 7, 2023
There was a problem hiding this comment.
Thank you for working on this PR, @alefesouza! The regex is correct, but the version number that we should apply it to is the one we get from the get_bloginfo. During my testing, I still encountered the same error. Perhaps we should consider applying a preg_replace on line 25!
|
@tarhi-saad fixed on ef429f1. |
tarhi-saad
force-pushed
the
fix/10563-wp-version-compare-casting-error
branch
from
674b9d9
to
757409d
Compare
tarhi-saad
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Hey, @alefesouza! 👋 Thanks a lot for taking care of this! 🙌 I'll merge the PR after the CI checks are done! 🎉
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #10563
Why
Fix casting error on
Utils::wp_version_comparewhen using a different PHP locale.Testing Instructions
While testing with
version_comparewith the French locale I could reproduce the errors mentioned on #10563, it looks like it didn't affectUtils::wp_version_comparemethod but as mentioned here: p1692776050961299/1692773342.122439-slack-C8X6Q7XQU it's fine to fix it defensively.php -asetlocale(LC_ALL, 'fr_FR');var_dump((float)6.4);float(6,4)(with the comma instead of dot), you need to install the fr_FR locale, for Docker you can run it on your container:require_once 'wp-load.php';require 'wp-content/plugins/woo-gutenberg-products-block/src/Utils/Utils.php'var_dump(\Automattic\WooCommerce\Blocks\Utils\Utils::wp_version_compare(6.4, '='));, changing the parameters, all output should run as expected, to simulate WordPress version you can run:global $wp_version; $wp_version = '6.4.0';WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).