This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add Product Collection Grid pattern #10660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.43 MB ℹ️ View Unchanged
|
kmanijak
added
type: enhancement
woocommercebot
requested review from
a team and
gigitux
and removed request for
a team
dinhtungdu
approved these changes
Aug 21, 2023
dinhtungdu
reviewed
Aug 21, 2023
According to the designs, yes 👍
I think "No Products" should be included. I'm not sure about pagination if the expectation is to keep one page only? @shaunandrews , could you clarify that part regarding Grid pattern (and other patterns) for Product Collection (AtfOeZIFizx7ASmoSUbNjD-fi-55-9579&t=rnEPoeIr070VybIn-0)? |
I'm merging this PR. I think it's better to include the pagination by default and in case it's not expected, we can always amend the pattern to display single page only. |
13 tasks
kmanijak
added a commit
that referenced
this pull request
Aug 25, 2023
imanish003
pushed a commit
that referenced
this pull request
Aug 28, 2023
* Add initial look of Full Grid Product Collection pattern * Refactor textAlign property of Product Button so it uses flex rather than text-align * Update Product Button text align after the fix * Remove debug log (#10719) * Add Product Collection Grid pattern (#10660) * Dispatch the `wc-blocks_render_blocks_frontend` event when rendering the empty cart block (#10619) * E2E: Refactor Mini Cart to be ready for fully parallel (#10704) * Revert dequeue add-to-cart-variation script which is needed to properly handle variable products in single product page (#10723) * Update alignment options to new setting --------- Co-authored-by: Thomas Roberts <[email protected]> Co-authored-by: Tung Du <[email protected]>
samueljseay
pushed a commit
that referenced
this pull request
Aug 29, 2023
* Add initial look of Full Grid Product Collection pattern * Refactor textAlign property of Product Button so it uses flex rather than text-align * Update Product Button text align after the fix * Remove debug log (#10719) * Add Product Collection Grid pattern (#10660) * Dispatch the `wc-blocks_render_blocks_frontend` event when rendering the empty cart block (#10619) * E2E: Refactor Mini Cart to be ready for fully parallel (#10704) * Revert dequeue add-to-cart-variation script which is needed to properly handle variable products in single product page (#10723) * Update alignment options to new setting --------- Co-authored-by: Thomas Roberts <[email protected]> Co-authored-by: Tung Du <[email protected]>
kmanijak
added
the
skip-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add Product Collection Grid pattern
Fixes #9368
Why
This is one of the patterns from a set of patterns we'd like to provide for Product Collection
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Known limitations:
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog