Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Audit: Google Listings & Ads #9212

Closed
Tracked by #9206
nielslange opened this issue Apr 26, 2023 · 7 comments
Closed
Tracked by #9206

Audit: Google Listings & Ads #9212

nielslange opened this issue Apr 26, 2023 · 7 comments
Assignees
Labels
category: extensibility Work involving adding or updating extensibility. Useful to combine with other scopes impacted.

Comments

@nielslange
Copy link
Member

Google Listings & Ads

This issue is to track compatibility testing between this extension and the Cart and Checkout blocks. See the epic for the audit template which should be completed and posted as a comment here once completed.

@nielslange nielslange added the category: extensibility Work involving adding or updating extensibility. Useful to combine with other scopes impacted. label Apr 26, 2023
@opr opr self-assigned this Apr 26, 2023
@opr
Copy link
Contributor

opr commented Apr 27, 2023

Extension Audit Template

Functionality Review

Allows merchants to automatically list their products on Google shopping and integrates Google Ads and Google merchant centre. It also adds analytics and fires events for some WooCommerce actions

This extension touches: (mark all that apply)

  • Products (Beta)
    • Product title
    • Product price
    • Product meta
    • Add to cart button
  • Single Product Pages
    • Product title
    • Product price
    • Product meta
    • Add to cart form
  • Cart Page
    • Cart items
    • Product title
    • Product price
    • Product meta
    • Product quantity
    • Cart totals
    • Notices
    • Custom functionality
  • Checkout Page
    • Checkout fields
    • Express checkout
    • Contact information
    • Shipping method
    • Pickup method
    • Shipping address
    • Billing address
    • Payment options
    • Checkout totals
    • Product title
    • Product price
    • Product meta
    • Product meta
    • Notices
    • Custom functionality
    • Order received page
  • My Account Page
  • Store API
    • Edits existing endpoint
    • Adds custom endpoint
  • Settings
    • WooCommerce settings
    • Custom settings page
    • Customizer

Compatibility with Blocks

  • Single Product Template - works OK, fires form_start and form_submit just like the regular PHP template based product.
  • Single product Block - same as above.

Issues identified:

  • 🚫 Products (Beta) - Does not fire the add_to_cart action like the shortcode products block does.
  • ⚠️ Order confirmation page - works ok for now, in most cases (sometimes it doesn't fire, but I don't think that's blocks specific) however be careful when the order confirmation page is blockified, we should ensure the action still fires.

Select those that apply:

  • Extension is already fully compatible with Blocks
  • Extension requires integration with Blocks
  • Extension requires fixes in the blocks context
  • Extension could be further enhanced to take advantage of Blocks

Integration Required

When the order confirmation page is blockified, we should ensure the action still fires.
In the Products (Beta) block, we should ensure the add_to_cart event is fired.

This extension requires integration with:

  • Cart Block
  • Checkout Block
  • Payment Methods API
  • Store API
  • Other

Integration Points

List specific integration points you think the extension will need in order to be supported in the Blocks context.

Location Type Description Effort
Products (Beta) Client API Ensuring the add_to_cart event is fired when adding an item via this block 2
Checkout (Order confirmation) Client API Ensuring the purchase event is fired when checking out with the blockified order confirmation page 2

@opr opr closed this as completed Apr 27, 2023
@pmcpinto
Copy link

@jconroy just a heads up that the GLA extension has a compatibility issue with the Products (Beta) block.

@jconroy
Copy link
Member

jconroy commented Jul 21, 2023

Thanks @pmcpinto

@mikkamp can you review and follow up with the team please? @puntope might be a good candidate for addressing.

@puntope
Copy link

puntope commented Jul 21, 2023

@mikkamp can you review and follow up with the team please? @puntope might be a good candidate for addressing.

If @mikkamp agrees, I can handle this in my porter next week. 👌

@mikkamp
Copy link
Contributor

mikkamp commented Jul 21, 2023

The add_to_cart hook is only used for analytics tracking and already has an alternative for blocks: https://github.com/woocommerce/google-listings-and-ads/blob/2.5.0/js/src/gtag-events/index.js#L18-L25

We can double check it though to make sure there wasn't any changes since we use the hook prefix experimental__woocommerce_blocks in case that's no longer experimental.

As for the Order Confirmation page, at the time of creating this wasn't fully "blockified" yet and was using a separate WP page which would call the hook. We can recheck this to make sure it's still valid.

⚠️ Order confirmation page - works ok for now, in most cases (sometimes it doesn't fire, but I don't think that's blocks specific) however be careful when the order confirmation page is blockified, we should ensure the action still fires.

@pmcpinto Do we have any details on which scenarios it doesn't fire even if it's not block specific?

@puntope I created a separate issue for it here which you can pick up during porter week.

@ralucaStan
Copy link
Contributor

When the order confirmation page is blockified, we should ensure the action still fires.
In the Products (Beta) block, we should ensure the add_to_cart event is fired.

@mikejolley could you check this one when you get the chance?

@puntope
Copy link

puntope commented Oct 9, 2023

When the order confirmation page is blockified, we should ensure the action still fires.
In the Products (Beta) block, we should ensure the add_to_cart event is fired.

@mikejolley could you check this one when you get the chance?

I was testing this again with Products (Beta) and Checkout Block

Both Add to Cart event and purchase were showing up in the GA Debugger

Add to Cart

Screen.Recording.2023-10-09.at.18.17.16.mov

Purchase

Screen.Recording.2023-10-09.at.18.12.32.mov

We will be happy if @mikejolley can confirm.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
category: extensibility Work involving adding or updating extensibility. Useful to combine with other scopes impacted.
Projects
None yet
Development

No branches or pull requests

7 participants