-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confirm compatibility with Blocks #2020
Comments
I checked this in the last version of WooCommerce and seems to be still |
Then Add to cart event doesn't trigger |
✅ This works for me with the classic Checkout page and also creating a new page and adding a Checkout block. The order confirmation shows the purchase event. I'm unsure if I need to do anything else to consider the Order confirmation page as "blockified" |
I see here we trigger the event when the "Add To Cart button click" happens... However, then we blocked the trigger for Blocks based Add to Cart button https://github.com/woocommerce/google-listings-and-ads/pull/1636/files#diff-05cafd66cd2e43b74298e2724b55d282f9054e7747d6e7f190f5f6769f8c4e51R72 It seems that the now |
Describe the issue:
As mentioned in woocommerce/woocommerce-blocks#9212 there could potentially be some compatibility issues with blockified content. In particular with the tracking code.
Tasks:
The
add_to_cart
hook is only used for analytics tracking and already has an alternative for blocks: https://github.com/woocommerce/google-listings-and-ads/blob/2.5.0/js/src/gtag-events/index.js#L18-L25Double check it though to make sure there wasn't any changes since we use the hook prefix
experimental__woocommerce_blocks
, in case that's no longer experimental.The Order Confirmation page, at the time of creating this wasn't fully "blockified" yet and was using a separate WP page which would call the hook. Recheck this to make sure it's still called with a fully blockified cart/checkout process.
We should also double check the following warning:
Uncover any details on which scenarios it doesn't fire.
The text was updated successfully, but these errors were encountered: