Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/363 - Fatal Error when WooCommerce is disabled #367

Merged
merged 6 commits into from
Oct 6, 2023
Merged

Conversation

faisal-alvi
Copy link
Member

All Submissions:

  • Does your code follow the WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changes proposed in this Pull Request:

This PR adds a check if the WooCommerce class exists, if not, it shows a message. This is inspired by the bookings' message.

Closes #363.

How to test the changes in this Pull Request:

  1. Activate WC, WC Booking and Accommodation-Bookings.
  2. Deactivate WC
  3. A message should appear at the top.
image

Other information:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changelog entry

Fix - Fatal Error when WooCommerce is disabled.

@faisal-alvi faisal-alvi added needs: regression The Issue/PR needs regresstion testing. needs: UAT labels Sep 4, 2023
@faisal-alvi faisal-alvi added this to the Future Release milestone Sep 4, 2023
@faisal-alvi faisal-alvi self-assigned this Sep 4, 2023
@ankitguptaindia
Copy link
Member

QA/Test Report-

Testing Environment -

  • WordPress: 6.3.1
  • Theme: Storefront Version: 4.5.2
  • WooCommerce - Version 8.0.3
  • PHP: 8.0.21
  • Web Server: Nginx
  • Browser: Chrome - Version 116
  • OS: macOS Monterey V 12.3.1
  • Git Branch: fix/363

Test Results - Issue has been fixed.

Next Step- Ready to Code Review(Woo) UAT

@ankitguptaindia
Copy link
Member

Regression+Smoke Test Report-

Testing Environment -

  • WordPress: 6.3.1
  • Theme: Storefront Version: 4.5.2
  • WooCommerce - Version 8.1.1
  • PHP: 8.0.22
  • Web Server: Nginx
  • Browser: Chrome - Version 115

Tested with Archive File created via

php woorelease.phar build smoke-testing branch _URL_

  • Composer version - 2.3.5
  • npm version - 8.19.3
  • node version - 16.19.1

Please note that this plugin has been tested with the build created by the specified versions ☝🏼 of Composer, Node, and NPM.

Status- Working as expected. Ready to merge 🚀

@ankitguptaindia ankitguptaindia removed needs: regression The Issue/PR needs regresstion testing. needs: UAT labels Sep 29, 2023
@vikrampm1 vikrampm1 modified the milestones: Future Release, 1.2.1 Oct 6, 2023
@vikrampm1 vikrampm1 marked this pull request as ready for review October 6, 2023 17:06
@vikrampm1 vikrampm1 merged commit d6e1fcd into trunk Oct 6, 2023
4 checks passed
@vikrampm1 vikrampm1 deleted the fix/363 branch October 6, 2023 17:06
@vikrampm1 vikrampm1 mentioned this pull request Oct 6, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal Error when WooCommerce is disabled and Accommodation Bookings is enabled with Booking.
4 participants