Change shops to shop's as it needs an apostrophe #2138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"shops appearance" - possessive so should be "shop's appearance". Or drop the s: "shop appearance" and avoid any questions about apostrophes.
Aljullu
reviewed
Sep 2, 2024
There was a problem hiding this comment.
Thanks for opening this PR, @damiencarbery! Good catch with the typo. I suggest using double quotes " to wrap the string, this way we don't need to escape the single quote '. I left the code suggestion inline below. 👇
| @@ -138,7 +138,7 @@ public function storefront_welcome_screen() { | |||
| <img src="<?php echo esc_url( get_template_directory_uri() ); ?>/assets/images/admin/welcome-screen/child-themes.jpg" alt="Storefront Powerpack" /> | |||
|
|
|||
| <p> | |||
| <?php esc_html_e( 'Quickly and easily transform your shops appearance with Storefront child themes.', 'storefront' ); ?> | |||
| <?php esc_html_e( 'Quickly and easily transform your shop\'s appearance with Storefront child themes.', 'storefront' ); ?> | |||
There was a problem hiding this comment.
Suggested change
| <?php esc_html_e( 'Quickly and easily transform your shop\'s appearance with Storefront child themes.', 'storefront' ); ?> | |
| <?php esc_html_e( "Quickly and easily transform your shop's appearance with Storefront child themes.", 'storefront' ); ?> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"shops appearance" - possessive so should be "shop's appearance". Or drop the s: "shop appearance" and avoid any questions about apostrophes.