Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.7.1
->1.0.0
2.3.0
->3.1.0
Release Notes
PHPCSStandards/composer-installer (dealerdirect/phpcodesniffer-composer-installer)
v1.0.0
Compare Source
Breaking changes
Dealerdirect
toPHPCSStandards
by @jrfnl in https://github.com/PHPCSStandards/composer-installer/pull/191What's Changed
master
branch by @Potherca in https://github.com/PHPCSStandards/composer-installer/pull/201CI / CD
fail-fast
with setup-php by @jrfnl in https://github.com/PHPCSStandards/composer-installer/pull/194Tests
InstalledPathsOrderTest
by @jrfnl in https://github.com/PHPCSStandards/composer-installer/pull/176InvalidPackagesTest
by @jrfnl in https://github.com/PHPCSStandards/composer-installer/pull/168PlayNiceWithScriptsTest
by @jrfnl in https://github.com/PHPCSStandards/composer-installer/pull/169PreexistingPHPCSConfigTest
by @jrfnl in https://github.com/PHPCSStandards/composer-installer/pull/166PreexistingPHPCSInstalledPathsConfigTest
+ bug fix by @jrfnl in https://github.com/PHPCSStandards/composer-installer/pull/167RemovePluginTest
by @jrfnl in https://github.com/PHPCSStandards/composer-installer/pull/177New Contributors
Full Changelog: PHPCSStandards/composer-installer@v0.7.2...v1.0.0
v0.7.2
Compare Source
What's Changed
config-show
always shows all by @jrfnl in https://github.com/PHPCSStandards/composer-installer/pull/154CI/CD
New Contributors
Full Changelog: PHPCSStandards/composer-installer@v0.7.1...v0.7.2
WordPress/WordPress-Coding-Standards (wp-coding-standards/wpcs)
v3.1.0
Compare Source
Added
Universal.PHP.LowercasePHPTag
sniff.Generic.CodeAnalysis.RequireExplicitBooleanOperatorPrecedence
and theUniversal.CodeAnalysis.NoDoubleNegative
sniffs.sanitize_locale_name()
function to the list of known "escaping" functions. Props [@Chouby]sanitize_locale_name()
function to the list of known "sanitize & unslash" functions. Props [@Chouby]Changed
PHP_CodeSniffer
version to 3.9.0 (was 3.7.2).PHPCSUtils
version to 1.0.10 (was 1.0.8).PHPCSExtra
version to 1.2.1 (was 1.1.0).Please ensure you run
composer update wp-coding-standards/wpcs --with-dependencies
to benefit from these updates.use
keyword for closureuse
statements will now consistently be checked. Props [@westonruter] for reporting.minimum_wp_version
, as used by a number of sniffs detecting usage of deprecated WP features, has been updated to6.2
.WordPress.NamingConventions.PrefixAllGlobals
has been updated to recognize pluggable functions introduced in WP 6.4 and 6.5.WordPress.NamingConventions.ValidPostTypeSlug
has been updated to recognize reserved post types introduced in WP 6.4 and 6.5.WordPress.WP.ClassNameCase
has been updated to recognize classes introduced in WP 6.4 and 6.5.WordPress.WP.DeprecatedClasses
now detects classes deprecated in WordPress up to WP 6.5.WordPress.WP.DeprecatedFunctions
now detects functions deprecated in WordPress up to WP 6.5.IsUnitTestTrait
will now recognize classes which extend the new WP CoreWP_Font_Face_UnitTestCase
class as test classes.Fixed
WordPress.WP.PostsPerPage
could potentially result in anInternal.Exception
when encountering a query string which doesn't include the value forposts_per_page
in the query string. Props [@anomiex] for reporting.v3.0.1
Compare Source
Added
WordPress.Security.EscapeOutput
sniff was updated to report unescaped message parameters passed to exceptions created inthrow
statements. This specific violation now has a separate error code:ExceptionNotEscaped
. This will allow users to ignore or exclude that specific error code. Props [@anomiex].The error code(s) for other escaping issues flagged by the sniff remain unchanged.
Changed
Fixed
phpcs.xml.dist.sample
file (case-sensitive sniff name). Props [@dawidurbanski].v3.0.0
Compare Source
Important information about this release:
At long last... WordPressCS 3.0.0 is here.
This is an important release which makes significant changes to improve the accuracy, performance, stability and maintainability of all sniffs, as well as making WordPressCS much better at handling modern PHP.
WordPressCS 3.0.0 contains breaking changes, both for people using ignore annotations, people maintaining custom rulesets, as well as for sniff developers who maintain a custom PHPCS standard based on WordPressCS.
If you are an end-user or maintain a custom WordPressCS based ruleset, please start by reading the Upgrade Guide to WordPressCS 3.0.0 for end-users which lists the most important changes and contains a step by step guide for upgrading.
If you are a maintainer of an external standard based on WordPressCS and any of your custom sniffs are based on or extend WordPressCS sniffs, please read the Upgrade Guide to WordPressCS 3.0.0 for Developers.
In all cases, please read the complete changelog carefully before you upgrade.
Added
While support in external sniffs used by WordPressCS has not be exhaustively verified, a lot of work has been done to try and add support for new PHP syntaxes to those as well.
WordPressCS native sniffs and utilities have received fixes for the following syntaxes:
false
andnull
types.$object::class
WordPress.CodeAnalysis.AssignmentInTernaryCondition
sniff to theWordPress-Core
ruleset which partially replaces the removedWordPress.CodeAnalysis.AssignmentInCondition
sniff.WordPress.WhiteSpace.ObjectOperatorSpacing
sniff which replaces the use of theSquiz.WhiteSpace.ObjectOperatorSpacing
sniff in theWordPress-Core
ruleset.WordPress.WP.ClassNameCase
sniff to theWordPress-Core
ruleset, to check that any class name references to WP native classes and classes from external dependencies use the case of the class as per the class declaration.WordPress.WP.Capabilities
sniff to theWordPress-Extra
ruleset. This sniff checks that valid capabilities are used, not roles or user levels. Props, amongst others, to [@grappler] and [@khacoder].Custom capabilities can be added to the sniff via a
custom_capabilities
ruleset property.The sniff also supports the
minimum_wp_version
property to allow the sniff to accurately determine how the use of deprecated capabilities should be flagged.WordPress.WP.CapitalPDangit
sniff contains a new check to verify the correct spelling ofWordPress
in namespace names.WordPress.WP.I18n
sniff contains a newEmptyTextDomain
error code for an empty text string being passed as the text domain, which overrules the default value of the parameter and renders a text untranslatable.WordPress.DB.PreparedSQLPlaceholders
sniff has been expanded with additional checks for the correct use of the%i
placeholder, which was introduced in WP 6.2. Props [@craigfrancis].The sniff now also supports the
minimum_wp_version
ruleset property to determine whether the%i
placeholder can be used.WordPress-Core
: the following additional sniffs (or select error codes from these sniffs) have been added to the ruleset:Generic.CodeAnalysis.AssignmentInCondition
,Generic.CodeAnalysis.EmptyPHPStatement
(replaces the WordPressCS native sniff),Generic.VersionControl.GitMergeConflict
,Generic.WhiteSpace.IncrementDecrementSpacing
,Generic.WhiteSpace.LanguageConstructSpacing
,Generic.WhiteSpace.SpreadOperatorSpacingAfter
,PSR2.Classes.ClassDeclaration
,PSR2.Methods.FunctionClosingBrace
,PSR12.Classes.ClassInstantiation
,PSR12.Files.FileHeader
(select error codes only),PSR12.Functions.NullableTypeDeclaration
,PSR12.Functions.ReturnTypeDeclaration
,PSR12.Traits.UseDeclaration
,Squiz.Functions.MultiLineFunctionDeclaration
(replaces part of theWordPress.WhiteSpace.ControlStructureSpacing
sniff),Modernize.FunctionCalls.Dirname
,NormalizedArrays.Arrays.ArrayBraceSpacing
(replaces part of theWordPress.Arrays.ArrayDeclarationSpacing
sniff),NormalizedArrays.Arrays.CommaAfterLast
(replaces the WordPressCS native sniff),Universal.Classes.ModifierKeywordOrder
,Universal.Classes.RequireAnonClassParentheses
,Universal.Constants.LowercaseClassResolutionKeyword
,Universal.Constants.ModifierKeywordOrder
,Universal.Constants.UppercaseMagicConstants
,Universal.Namespaces.DisallowCurlyBraceSyntax
,Universal.Namespaces.DisallowDeclarationWithoutName
,Universal.Namespaces.OneDeclarationPerFile
,Universal.NamingConventions.NoReservedKeywordParameterNames
,Universal.Operators.DisallowShortTernary
(replaces the WordPressCS native sniff),Universal.Operators.DisallowStandalonePostIncrementDecrement
,Universal.Operators.StrictComparisons
(replaces the WordPressCS native sniff),Universal.Operators.TypeSeparatorSpacing
,Universal.UseStatements.DisallowMixedGroupUse
,Universal.UseStatements.KeywordSpacing
,Universal.UseStatements.LowercaseFunctionConst
,Universal.UseStatements.NoLeadingBackslash
,Universal.UseStatements.NoUselessAliases
,Universal.WhiteSpace.CommaSpacing
,Universal.WhiteSpace.DisallowInlineTabs
(replaces the WordPressCS native sniff),Universal.WhiteSpace.PrecisionAlignment
(replaces the WordPressCS native sniff),Universal.WhiteSpace.AnonClassKeywordSpacing
.WordPress-Extra
: the following additional sniffs have been added to the ruleset:Generic.CodeAnalysis.UnusedFunctionParameter
,Universal.Arrays.DuplicateArrayKey
,Universal.CodeAnalysis.ConstructorDestructorReturn
,Universal.CodeAnalysis.ForeachUniqueAssignment
,Universal.CodeAnalysis.NoEchoSprintf
,Universal.CodeAnalysis.StaticInFinalClass
,Universal.ControlStructures.DisallowLonelyIf
,Universal.Files.SeparateFunctionsFromOO
.WordPress.Utils.I18nTextDomainFixer
: theload_script_textdomain()
function to the functions the sniff looks for.WordPress.WP.AlternativeFunctions
: the following PHP native functions have been added to the sniff and will now be flagged when used:unlink()
(in a newunlink
group) ,rename()
(in a newrename
group),chgrp()
,chmod()
,chown()
,is_writable()
is_writeable()
,mkdir()
,rmdir()
,touch()
,fputs()
(in the existingfile_system_operations
group, which was previously namedfile_system_read
). Props [@sandeshjangam] and [@JDGrimes].PHPUnit_Adapter_TestCase
class to the list of "known test (case) classes".antispambot()
function to the list of known "formatting" functions.esc_xml()
andwp_kses_one_attr()
functions to the list of known "escaping" functions.wp_timezone_choice()
andwp_readonly()
functions to the list of known "auto escaping" functions.sanitize_url()
andwp_kses_one_attr()
functions to the list of known "sanitizing" functions.WordPress.WhiteSpace.ControlStructureSpacing
sniff. These can be displayed using--report=info
when theblank_line_check
property has been set totrue
.WordPress.DateTime.RestrictedFunctions
,WordPress.NamingConventions.PrefixAllGlobals
(props [@Ipstenu]),WordPress.PHP.StrictInArray
(props [@marconmartins]),WordPress.PHP.YodaConditions
(props [@Ipstenu]),WordPress.WhiteSpace.ControlStructureSpacing
(props [@ckanitz]),WordPress.WhiteSpace.ObjectOperatorSpacing
,WordPress.WhiteSpace.OperatorSpacing
(props [@ckanitz]),WordPress.WP.CapitalPDangit
(props [@NielsdeBlaauw]),WordPress.WP.Capabilities
,WordPress.WP.ClassNameCase
,WordPress.WP.EnqueueResourceParameters
(props [@NielsdeBlaauw]).This documentation can be exposed via the
PHP_CodeSniffer
--generator=...
command-line argument.Note: all sniffs which have been added from PHPCSExtra (Universal, Modernize, NormalizedArrays sniffs) are also fully documented.
Added (internal/dev-only)
ArrayWalkingFunctionsHelper
ConstantsHelper
*ContextHelper
*DeprecationHelper
*FormattingFunctionsHelper
ListHelper
*RulesetPropertyHelper
*SnakeCaseHelper
*UnslashingFunctionsHelper
ValidationHelper
VariableHelper
*WPGlobalVariablesHelper
WPHookHelper
EscapingFunctionsTrait
IsUnitTestTrait
MinimumWPVersionTrait
PrintingFunctionsTrait
SanitizationHelperTrait
*WPDBTrait
These classes and traits mostly contain pre-existing functionality moved from the
Sniff
class.The classes marked with an
*
are considered internal and do not have any promise of future backward compatibility.More information is available in the Upgrade Guide to WordPressCS 3.0.0 for Developers.
Changed
Installing in a different manner (git clone/PEAR/PHAR) is still possible, but no longer supported.
PHP_CodeSniffer
version to 3.7.2 (was 3.3.1).filter
,libxml
andXMLReader
extensions are now explicitly required.It is recommended to also have the
Mbstring
andiconv
extensions enabled for the most accurate results.master
tomain
.WordPress-Extra
toWordPress-Core
: theGeneric.Files.OneObjectStructurePerFile
(also changed fromwarning
toerror
),Generic.PHP.BacktickOperator
,PEAR.Files.IncludingFile
,PSR2.Classes.PropertyDeclaration
,PSR2.Methods.MethodDeclaration
,Squiz.Scope.MethodScope
,Squiz.WhiteSpace.ScopeKeywordSpacing
sniffs. Props, amongst others, to [@desrosj].WordPress-Core
: TheGeneric.Arrays.DisallowShortArraySyntax
sniff has been replaced by theUniversal.Arrays.DisallowShortArraySyntax
sniff.The new sniff will recognize short lists correctly and ignore them.
WordPress-Core
: TheGeneric.Files.EndFileNewline
sniff has been replaced by the more comprehensivePSR2.Files.EndFileNewline
sniff.This could be done in two different ways:
minimum_supported_version
property for each sniff from a ruleset.--runtime-set minimum_supported_wp_version #.#
on the command line.The names of the property and the CLI setting have now been aligned to both use
minimum_wp_version
as the name.Both ways of passing the value are still supported.
WordPress.NamingConventions.PrefixAllGlobals
: thecustom_test_class_whitelist
property has been renamed tocustom_test_classes
.WordPress.NamingConventions.ValidVariableName
: thecustomPropertiesWhitelist
property has been renamed toallowed_custom_properties
.WordPress.PHP.NoSilencedErrors
: thecustom_whitelist
property has been renamed tocustomAllowedFunctionsList
.WordPress.PHP.NoSilencedErrors
: theuse_default_whitelist
property has been renamed tousePHPFunctionsList
.WordPress.WP.GlobalVariablesOverride
: thecustom_test_class_whitelist
property has been renamed tocustom_test_classes
.custom_test_classes
(previouslycustom_test_class_whitelist
) ruleset property.minimum_supported_wp_version
, as used by a number of sniffs detecting usage of deprecated WP features, has been updated to6.0
.WordPress.NamingConventions.PrefixAllGlobals
now takes new pluggable constants into account as introduced in WordPress up to WP 6.3.WordPress.NamingConventions.ValidPostTypeSlug
now takes new reserved post types into account as introduced in WordPress up to WP 6.3.WordPress.WP.DeprecatedClasses
now detects classes deprecated in WordPress up to WP 6.3.WordPress.WP.DeprecatedFunctions
now detects functions deprecated in WordPress up to WP 6.3.WordPress.WP.DeprecatedParameters
now detects parameters deprecated in WordPress up to WP 6.3.WordPress.WP.DeprecatedParameterValues
now detects parameter values deprecated in WordPress up to WP 6.3.WordPress.Utils.I18nTextDomainFixer
: the lists of recognized plugin and theme header tags has been updated based on the current information in the plugin and theme handbooks.WordPress.WP.AlternativeFunctions
: the "group" namefile_system_read
, which can be used with theexclude
property, has been renamed tofile_system_operations
.This also means that the error codes for individual functions flagged via that group have changed from
WordPress.WP.AlternativeFunctions.file_system_read_*
toWordPress.WP.AlternativeFunctions.file_system_operations_*
.WordPress.WP.CapitalPDangit
: theMisspelled
error code has been split into two error codes -MisspelledInText
andMisspelledInComment
- to allow for more modular exclusions/selectively turning off the auto-fixer for the sniff.WordPress.WP.I18n
no longer throws both theMissingSingularPlaceholder
and theMismatchedPlaceholders
for the same code, as the errors have an overlap.WordPress-Core
: previously only the spacing around commas in arrays, function declarations and function calls was checked. Now, the spacing around commas will be checked in all contexts.WordPress.Arrays.ArrayKeySpacingRestrictions
: a newSpacesBetweenBrackets
error code has been introduced for the spacing between square brackets for array assignments without key. Previously, this would throw aNoSpacesAroundArrayKeys
error with an unclear error message.WordPress.Files.FileName
now recognizes more word separators, meaning that files using other word separators than underscores will now be flagged for not using hyphenation.WordPress.Files.FileName
now checks if a file contains a test class and if so, will bow out.This change was made to prevent issues with PHPUnit 9.1+, which strongly prefers PSR4-style file names.
Whether something is test class or not is based on a pre-defined list of "known" test case classes which can be extended and, optionally, a list of user provided test case classes provided via setting the
custom_test_classes
property in a custom ruleset or the complete test directory can be excluded via a custom ruleset.WordPress.NamingConventions.PrefixAllGlobals
now allows for pluggable functions and classes, which should not be prefixed when "plugged".WordPress.PHP.NoSilencedErrors
: the metric, which displays in theinfo
report, has been renamed from "whitelisted function call" to "silencing allowed function call".WordPress.Security.EscapeOutput
now flags the use ofget_search_query( false )
when generating output (as thefalse
turns off the escaping).WordPress.Security.EscapeOutput
now also examines parameters passed for exception creation inthrow
statements and expressions for correct escaping.WordPress.Security.ValidatedSanitizedInput
now examines all superglobal (except for$GLOBALS
). Previously, the$_SESSION
and$_ENV
superglobals would not be flagged as needing validation/sanitization.WordPress.WP.I18n
now recognizes the new PHP 8.0+h
andH
type specifiers.WordPress.WP.PostsPerPage
has improved recognition for numbers prefixed with a unary operator and non-decimal numbers.WordPress.DB.PreparedSQL
will identify more precisely the code which is problematic.WordPress.DB.PreparedSQLPlaceholders
will identify more precisely the code which is problematic.WordPress.DB.SlowDBQuery
will identify more precisely the code which is problematic.WordPress.Security.PluginMenuSlug
: the error will now be thrown more precisely on the code which triggered the error. Depending on code layout, this may mean that an error will now be thrown on a different line.WordPress.WP.DiscouragedConstants
: the error will now be thrown more precisely on the code which triggered the error. Depending on code layout, this may mean that an error will now be thrown on a different line.WordPress.WP.EnqueuedResourceParameters
: the error will now be thrown more precisely on the code which triggered the error. Depending on code layout, this may mean that an error will now be thrown on a different line.WordPress.WP.I18n
: the errors will now be thrown more precisely on the code which triggered the error. Depending on code layout, this may mean that an error will now be thrown on a different line.WordPress.WP.PostsPerPage
will identify more precisely the code which is problematic.WordPress.PHP.TypeCasts.UnsetFound
has been changed from awarning
to anerror
as the(unset)
cast is no longer available in PHP 8.0 and higher.WordPress.WP.EnqueuedResourceParameters.MissingVersion
has been changed from anerror
to awarning
.WordPress.Arrays.ArrayKeySpacingRestrictions
: improved the clarity of the error messages for theTooMuchSpaceBeforeKey
andTooMuchSpaceAfterKey
error codes.WordPress.CodeAnalysis.EscapedNotTranslated
: improved the clarity of the error message.WordPress.PHP.IniSet
: improved the clarity of the error messages for the sniff.WordPress.PHP.PregQuoteDelimiter
: improved the clarity of the error message for theMissing
error code.WordPress.PHP.RestrictedFunctions
: improved the clarity of the error messages for the sniff.WordPress.PHP.RestrictedPHPFunctions
: improved the error message for thecreate_function_create_function
error code.WordPress.PHP.TypeCast
: improved the clarity of the error message for theUnsetFound
error code. It will no longer advise assigningnull
.WordPress.Security.SafeRedirect
: improved the clarity of the error message. (very minor)WordPress.Security.ValidatedSanitizedInput
: improved the clarity of the error messages for theMissingUnslash
error code.WordPress.WhiteSpace.CastStructureSpacing
: improved the clarity of the error message for theNoSpaceBeforeOpenParenthesis
error code.WordPress.WP.I18n
: improved the clarity of the error messages for the sniff.WordPress.WP.I18n
: the error messages will now use the correct parameter name.WordPress.CodeAnalysis.EscapedNotTranslated
,WordPress.NamingConventions.PrefixAllGlobals
,WordPress.NamingConventions.ValidPostTypeSlug
,WordPress.PHP.IniSet
, and theWordPress.PHP.NoSilencedErrors
sniff will now display the code sample found without comments and extranuous whitespace.Changed (internal/dev-only)
final
with the exception of the following four classes which are known to be extended by external PHPCS standards build on top of WordPressCS:WordPress.NamingConventions.ValidHookName
,WordPress.Security.EscapeOutput
,WordPress.Security.NonceVerification
,WordPress.Security.ValidatedSanitizedInput
.WordPressCS\WordPress\Sniff
class, have been moved to dedicated Helper classes and traits or, in some cases, to the sniff class using them.As this change is only relevant for extenders, the full details of these moves are not included in this changelog, but can be found in the Developers Upgrade Guide to WordPressCS 3.0.0
public
properties, which were used by multiple sniffs, have been moved from*Sniff
classes to traits. Again, the full details of these moves are not included in this changelog, but can be found in the Developers Upgrade Guide to WordPressCS 3.0.0As this change is only relevant for extenders, the full details of these renames are not included in this changelog, but can be found in the Developers Upgrade Guide to WordPressCS 3.0.0
AbstractFunctionRestrictionsSniff
: Thewhitelist
key in the$groups
array property has been renamed toallow
.WordPress.NamingConventions.ValidFunctionName
sniff no longer extends the similar PHPCS nativePEAR
sniff.Removed
WordPress.Arrays.CommaAfterArrayItem
sniff (replaced by theNormalizedArrays.Arrays.CommaAfterLast
and theUniversal.WhiteSpace.CommaSpacing
sniffs).WordPress.Classes.ClassInstantiation
sniff (replaced by thePSR12.Classes.ClassInstantiation
,Universal.Classes.RequireAnonClassParentheses
andUniversal.WhiteSpace.AnonClassKeywordSpacing
sniffs).WordPress.CodeAnalysis.AssignmentInCondition
sniff (replaced by theGeneric.CodeAnalysis.AssignmentInCondition
and theWordPress.CodeAnalysis.AssignmentInTernaryCondition
sniffs).WordPress.CodeAnalysis.EmptyStatement
sniff (replaced by theGeneric.CodeAnalysis.EmptyPHPStatement
sniff).WordPress.PHP.DisallowShortTernary
sniff (replaced by theUniversal.Operators.DisallowShortTernary
sniff).WordPress.PHP.StrictComparisons
sniff (replaced by theUniversal.Operators.StrictComparisons
sniff).WordPress.WhiteSpace.DisallowInlineTabs
sniff (replaced by theUniversal.WhiteSpace.DisallowInlineTabs
sniff).WordPress.WhiteSpace.PrecisionAlignment
sniff (replaced by theUniversal.WhiteSpace.PrecisionAlignment
sniff).WordPress.WP.TimezoneChange
sniff (replaced by theWordPress.DateTime.RestrictedFunctions
sniff). This sniff was previously already deprecated.WordPress-Extra
: TheSquiz.WhiteSpace.LanguageConstructSpacing
sniff (replaced by the added, more comprehensiveGeneric.WhiteSpace.LanguageConstructSpacing
sniff in theWordPress-Core
ruleset).WordPress.Arrays.ArrayDeclarationSpacing
: array brace spacing checks (replaced by theNormalizedArrays.Arrays.ArrayBraceSpacing
sniff).WordPress.WhiteSpace.ControlStructureSpacing
: checks for the spacing for function declarations (replaced by theSquiz.Functions.MultiLineFunctionDeclaration
sniff).Includes removal of the
spaces_before_closure_open_paren
property for this sniff.WordPress.WP.I18n
: thecheck_translator_comments
property.Exclude the
WordPress.WP.I18n.MissingTranslatorsComment
and theWordPress.WP.I18n.TranslatorsCommentWrongStyle
error codes instead.This is a PHP parse error since PHP 7.0. Use the
PHPCompatibilityWP
standard to check for PHP cross-version compatibility issues.WordPress.Arrays.ArrayKeySpacingRestrictions.MissingBracketCloser
error code as sniffs should not report on parse errors.WordPress.CodeAnalysis.AssignmentIn[Ternary]Condition.NonVariableAssignmentFound
error code as sniffs should not report on parse errors.Block_Supported_Styles_Test
class will no longer incorrectly be recognized as an extendable test case class.Removed (internal/dev-only)
AbstractArrayAssignmentRestrictionsSniff
: support for the optional'callback'
key in the array returned bygetGroups()
.WordPressCS\WordPress\PHPCSHelper
class (use thePHPCSUtils\BackCompat\Helper
class instead).WordPressCS\WordPress\Sniff::addMessage()
method (use thePHPCSUtils\Utils\MessageHelper::addMessage()
method instead).WordPressCS\WordPress\Sniff::addFixableMessage()
method (use thePHPCSUtils\Utils\MessageHelper::addFixableMessage()
method instead).WordPressCS\WordPress\Sniff::determine_namespace()
method (use thePHPCSUtils\Utils\Namespaces::determineNamespace()
method instead).WordPressCS\WordPress\Sniff::does_function_call_have_parameters()
method (use thePHPCSUtils\Utils\PassedParameters::hasParameters()
method instead).WordPressCS\WordPress\Sniff::find_array_open_close()
method (use thePHPCSUtils\Utils\Arrays::getOpenClose()
method instead).WordPressCS\WordPress\Sniff::find_list_open_close()
method (use thePHPCSUtils\Utils\Lists::getOpenClose()
method instead).WordPressCS\WordPress\Sniff::get_declared_namespace_name()
method (use thePHPCSUtils\Utils\Namespaces::getDeclaredName()
method instead).WordPressCS\WordPress\Sniff::get_function_call_parameter_count()
method (use thePHPCSUtils\Utils\PassedParameters::getParameterCount()
method instead).WordPressCS\WordPress\Sniff::get_function_call_parameters()
method (use thePHPCSUtils\Utils\PassedParameters::getParameters()
method instead).WordPressCS\WordPress\Sniff::get_function_call_parameter()
method (use thePHPCSUtils\Utils\PassedParameters::getParameter()
method instead).WordPressCS\WordPress\Sniff::get_interpolated_variables()
method (use thePHPCSUtils\Utils\TextStrings::getEmbeds()
method instead).WordPressCS\WordPress\Sniff::get_last_ptr_on_line()
method (no replacement available at this time).WordPressCS\WordPress\Sniff::get_use_type()
method (use thePHPCSUtils\Utils\UseStatements::getType()
method instead).WordPressCS\WordPress\Sniff::has_whitelist_comment()
method (no replacement).WordPressCS\WordPress\Sniff::$hookFunctions
property (no replacement available at this time).WordPressCS\WordPress\Sniff::init()
method (no replacement).WordPressCS\WordPress\Sniff::is_class_constant()
method (use thePHPCSUtils\Utils\Scopes::isOOConstant()
method instead).WordPressCS\WordPress\Sniff::is_class_property()
method (use thePHPCSUtils\Utils\Scopes::isOOProperty()
method instead).WordPressCS\WordPress\Sniff::is_foreach_as()
method (use thePHPCSUtils\Utils\Context::inForeachCondition()
method instead).WordPressCS\WordPress\Sniff::is_short_list()
method (depending on your needs, use thePHPCSUtils\Utils\Lists::isShortList()
or thePHPCSUtils\Utils\Arrays::isShortArray()
method instead).WordPressCS\WordPress\Sniff::is_token_in_test_method()
method (no replacement available at this time).WordPressCS\WordPress\Sniff::REGEX_COMPLEX_VARS
constant (use the PHPCSUtilsPHPCSUtils\Utils\TextStrings::stripEmbeds()
andPHPCSUtils\Utils\TextStrings::getEmbeds()
methods instead).WordPressCS\WordPress\Sniff::string_to_errorcode()
method (use thePHPCSUtils\Utils\MessageHelper::stringToErrorcode()
method instead).WordPressCS\WordPress\Sniff::strip_interpolated_variables()
method (use thePHPCSUtils\Utils\TextStrings::stripEmbeds()
method instead).WordPressCS\WordPress\Sniff::strip_quotes()
method (use thePHPCSUtils\Utils\TextStrings::stripQuotes()
method instead).WordPressCS\WordPress\Sniff::valid_direct_scope()
method (use thePHPCSUtils\Utils\Scopes::validDirectScope()
method instead).bin
directory.Fixed
This fixes various false positives and false negatives.
minimum_wp_version
property (previouslyminimum_supported_version
) will no longer throw a "passing null to non-nullable" deprecation notice on PHP 8.1+.WordPress.WhiteSpace.ControlStructureSpacing
no longer throws aTypeError
on PHP 8.0+.WordPress.NamingConventions.PrefixAllGlobals
no longer throws a "passing null to non-nullable" deprecation notice on PHP 8.1+.WordPress.WP.I18n
no longer throws a "passing null to non-nullable" deprecation notice on PHP 8.1+.VariableHelper::is_comparison()
(previouslySniff::is_comparison()
): fixed risk of undefined array key notice when scanning code containing parse errors.AbstractArrayAssignmentRestrictionsSniff
could previously get confused when it encountered comments in unexpected places.This fix has a positive impact on all sniffs which are based on this abstract (2 sniffs).
AbstractArrayAssignmentRestrictionsSniff
no longer examines numeric string keys as PHP treats those as integer keys, which were never intended as the target of this abstract.This fix has a positive impact on all sniffs which are based on this abstract (2 sniffs).
AbstractArrayAssignmentRestrictionsSniff
in case of duplicate entries, the sniff will now only examine the last value, as that's the value PHP will see.This fix has a positive impact on all sniffs which are based on this abstract (2 sniffs).
AbstractArrayAssignmentRestrictionsSniff
now determines the assigned value with higher accuracy.This fix has a positive impact on all sniffs which are based on this abstract (2 sniffs).
AbstractClassRestrictionsSniff
now treats thenamespace
keyword when used as an operator case-insensitively.This fix has a positive impact on all sniffs which are based on this abstract (3 sniffs).
AbstractClassRestrictionsSniff
now treats the hierarchy keywords (self
,parent
,static
) case-insensitively.This fix has a positive impact on all sniffs which are based on this abstract (3 sniffs).
AbstractClassRestrictionsSniff
now limits itself correctly when trying to find a class name before a::
.This fix has a positive impact on all sniffs which are based on this abstract (3 sniffs).
AbstractClassRestrictionsSniff
: false negatives on class instantiation statements ending on a PHP close tag.This fix has a positive impact on all sniffs which are based on this abstract (3 sniffs).
AbstractClassRestrictionsSniff
: false negatives on class instantiation statements combined with method chaining.This fix has a positive impact on all sniffs which are based on this abstract (3 sniffs).
AbstractFunctionRestrictionsSniff
: false positives on function declarations when the function returns by reference.This fix has a positive impact on all sniffs which are based on this abstract (nearly half of the WordPressCS sniffs).
AbstractFunctionRestrictionsSniff
: false positives on instantiation of a class with the same name as a targeted function.This fix has a positive impact on all sniffs which are based on this abstract (nearly half of the WordPressCS sniffs).
AbstractFunctionRestrictionsSniff
now respects that function names in PHP are case-insensitive in more places.This fix has a positive impact on all sniffs which are based on this abstract (nearly half of the WordPressCS sniffs).
These fixes have a positive impact on all sniffs using these methods.
minimum_wp_version
property (previouslyminimum_supported_version
) will now be more precise.WordPress.Arrays.ArrayIndentation
now ignores indentation issues for array items which are not the first thing on a line. This fixes a potential fixer conflict.WordPress.Arrays.ArrayKeySpacingRestrictions
: signed positive integer keys will now be treated the same as signed negative integer keys.WordPress.Arrays.ArrayKeySpacingRestrictions
: keys consisting of calculations will now be recognized more accurately.WordPress.Arrays.ArrayKeySpacingRestrictions.NoSpacesAroundArrayKeys
: now has better protection in case of a fixer conflict.WordPress.Classes.ClassInstantiation
could create parse errors when fixing a class instantiation using variable variables. This has been fixed by replacing the sniff with thePSR12.Classes.ClassInstantiation
sniff (and some others).WordPress.DB.DirectDatabaseQuery
could previously get confused when it encountered comments in unexpected places.WordPress.DB.DirectDatabaseQuery
now respects that function (method) names in PHP are case-insensitive.WordPress.DB.DirectDatabaseQuery
now only looks at the current statement to find a method call to the$wpdb
object.WordPress.DB.DirectDatabaseQuery
no longer warns aboutTRUNCATE
queries as those cannot be cached and need a direct database query.WordPress.DB.PreparedSQL
could previously get confused when it encountered comments in unexpected places.WordPress.DB.PreparedSQL
now respects that function names in PHP are case-insensitive.WordPress.DB.PreparedSQL
improved recognition of interpolated variables and expressions in the$text
argument. This fixes both some false negatives as well as some false positives.WordPress.DB.PreparedSQL
stricter recognition of the$wpdb
variable in double quoted query strings.WordPress.DB.PreparedSQL
false positive for floating point numbers concatenated into an SQL query.WordPress.DB.PreparedSQLPlaceholders
could previously get confused when it encountered comments in unexpected places.WordPress.DB.PreparedSQLPlaceholders
now respects that function names in PHP are case-insensitive.WordPress.DB.PreparedSQLPlaceholders
stricter recognition of the$wpdb
variable in double quotes query strings.WordPress.DB.PreparedSQLPlaceholders
false positive when a fully qualified function call is encountered in animplode( ', ', array_fill(...))
pattern.WordPress.Files.FileName
no longer presumes a three character file extension.WordPress.NamingConventions.PrefixAllGlobals
could previously get confused when it encountered comments in unexpected places in function calls which were being examined.WordPress.NamingConventions.PrefixAllGlobals
now respects that function names in PHP are case-insensitive when checking whether a function declaration is polyfilling a PHP native function.WordPress.NamingConventions.PrefixAllGlobals
improved false positive prevention for variable assignments via keyed lists.WordPress.NamingConventions.PrefixAllGlobals
now only looks at the current statement when determining which variablesConfiguration
📅 Schedule: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.