-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Tests #148
Custom Tests #148
Conversation
This reverts commit 8a1c83f.
Hi @Luc45 - I have tested both PRs and noticed some issues while running the different commands:
|
Howdy @rcstr , can you please confirm that your local Manager is in the correct branch (the counterpart of this one on the Manager repo)? And when you do your manual test where |
For the self-tests part (not manual testing), I can see some things:
This is probably a racing condition where we invoke the method to delete the
I think this only happens on the context of self-tests. I'll add a small workaround (probably a 250ms wait before deleting) to see if it addresses it in the context of self-tests. I won't change anything in the actual production flow, so if there's a bug there about this it will continue to happen on Mac and we can catch it. As for this failure:
From the snapshot tests it seems your instance of Docker adds some unexpected output to the terminal, which is nice to catch. I'll add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work on this @Luc45!
Custom Tests
This PR allows Partner developers of the Woo marketplace to submit their own E2E tests to QIT, and to run the E2E tests that we make available to them.
Testing instructions
_tests/custom_tests
and runcomposer install
_tests/custom_tests/.env.sample
to_tests/custom_tests/.env
.env
with the necessary values./vendor/bin/paratest
, it should take around 5 minutes and passManual testing instructions
Explore the new commands added, which are:
Scaffold a test, upload it, list it and run it:
qit scaffold:e2e /tmp/foo
qit tag:upload automatewoo /tmp/foo
qit tag:list
qit run:e2e automatewoo --plugin woocommerce:activate
Publish another test tag
automatewoo-birthdays
qit run:e2e automatewoo-birthdays --plugin woocommerce:activate --plugin automatewoo:test
qit-env.yml
orqit-env.json
filesThere are many options, try out with
--php_version 8.3
, different WP and Woo versions, object cache, etc.Also try out
--codegen
and--ui
.The self-tests is pretty self-explanatory too, if you're interested. Check this out for instance:
Documentation:
The documentation contains example commands that we can use to try more scenarios: https://qit.woo.com/docs/custom-tests/introduction