Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2597: Refactor ConnectMC with updated AccountCard #2657

Merged

Conversation

joemcgill
Copy link
Collaborator

This is a POC PR to implement the AccountCard suggestions from #2640 (review) for the ConnectMC component created in #2639.

@joemcgill joemcgill requested a review from asvinb October 30, 2024 20:51
@github-actions github-actions bot added the changelog: update Big changes to something that wasn't broken. label Oct 30, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.7%. Comparing base (7a4e40d) to head (c40800b).
Report is 69 commits behind head on update/2597-connect-mc-account.

Files with missing lines Patch % Lines
js/src/components/account-card/index.js 77.8% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                       @@
##           update/2597-connect-mc-account   #2657   +/-   ##
==============================================================
  Coverage                            62.7%   62.7%           
==============================================================
  Files                                 324     324           
  Lines                                5155    5161    +6     
  Branches                             1260    1265    +5     
==============================================================
+ Hits                                 3233    3237    +4     
- Misses                               1745    1747    +2     
  Partials                              177     177           
Flag Coverage Δ
js-unit-tests 62.7% <77.8%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
js/src/components/account-card/index.js 91.9% <77.8%> (-4.9%) ⬇️

@asvinb asvinb marked this pull request as ready for review October 31, 2024 11:02
@asvinb
Copy link
Collaborator

asvinb commented Oct 31, 2024

Changes LGTM @joemcgill . Merging.

@asvinb asvinb merged commit 7a757a2 into update/2597-connect-mc-account Oct 31, 2024
7 checks passed
@asvinb asvinb deleted the update/2597-connect-mc-refactor branch October 31, 2024 11:02
@eason9487 eason9487 added changelog: none Skip changelog entry for this PR and removed changelog: update Big changes to something that wasn't broken. labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: none Skip changelog entry for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants