Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Ads value prop in Paid Campaign performance card #2650

Merged
merged 42 commits into from
Nov 7, 2024
Merged

Show Ads value prop in Paid Campaign performance card #2650

merged 42 commits into from
Nov 7, 2024

Commits on Oct 22, 2024

  1. remove free credits

    @kt-12
    kt-12 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    d544759 View commit details
    Browse the repository at this point in the history

  2. add paid-features.js

    @kt-12
    kt-12 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    62d124c View commit details
    Browse the repository at this point in the history

  3. remove translations

    @kt-12
    kt-12 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    19ef7b1 View commit details
    Browse the repository at this point in the history

  4. e2e

    @kt-12
    kt-12 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    90ea27a View commit details
    Browse the repository at this point in the history

  5. style fixes and e2e

    @kt-12
    kt-12 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    2a7af58 View commit details
    Browse the repository at this point in the history

  6. fix e2e button clicking

    @kt-12
    kt-12 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    1ed56b8 View commit details
    Browse the repository at this point in the history

  7. fix old e2e

    @kt-12
    kt-12 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    cd2521c View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. address review feedback.

    @kt-12
    kt-12 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    d8cb4cc View commit details
    Browse the repository at this point in the history

  2. doc updated.

    @kt-12
    kt-12 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    cd58bca View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Update js/src/dashboard/summary-section/paid-features/free-ad-credit.js 

    adding fires info

Co-authored-by: Eason <[email protected]>
    @kt-12 @eason9487
    kt-12 and eason9487 authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    cfa279c View commit details
    Browse the repository at this point in the history

  2. Update js/src/dashboard/summary-section/paid-features/free-ad-credit.js 

    fix context

Co-authored-by: Eason <[email protected]>
    @kt-12 @eason9487
    kt-12 and eason9487 authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    96e4162 View commit details
    Browse the repository at this point in the history

  3. remove usage of sections, fix styling

    @kt-12
    kt-12 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    d5d1d2f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'feature/2538-performance-card-sep' of https://github.co… 

    …m/woocommerce/google-listings-and-ads into feature/2538-performance-card-sep
    @kt-12
    kt-12 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    e4fa585 View commit details
    Browse the repository at this point in the history

  5. remove margin

    @kt-12
    kt-12 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    d043e81 View commit details
    Browse the repository at this point in the history

  6. seperate file for paid-features test

    @kt-12
    kt-12 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    b77f18e View commit details
    Browse the repository at this point in the history

  7. fix button name

    @kt-12
    kt-12 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    cd7ec9f View commit details
    Browse the repository at this point in the history

  8. update variable names and cleanup

    @kt-12
    kt-12 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    6fe5003 View commit details
    Browse the repository at this point in the history

  9. cleanup

    @kt-12
    kt-12 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    51d5187 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'feature/2460-google-ads-value-prop' into feature/2538-p… 

    …erformance-card-sep
    @kt-12
    kt-12 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    ccc7edc View commit details
    Browse the repository at this point in the history

  11. check when ads complete is set

    @kt-12
    kt-12 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    2d77db8 View commit details
    Browse the repository at this point in the history

  12. change variable name

    @kt-12
    kt-12 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    0fcba0f View commit details
    Browse the repository at this point in the history

  13. avoide flakyness

    @kt-12
    kt-12 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    38318b2 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. change variable name

    @kt-12
    kt-12 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    2297982 View commit details
    Browse the repository at this point in the history

  2. remove additional assignement

    @kt-12
    kt-12 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    f8f9c4a View commit details
    Browse the repository at this point in the history

  3. style changes

    @kt-12
    kt-12 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    d7d17ad View commit details
    Browse the repository at this point in the history

  4. update E2E

    @kt-12
    kt-12 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    311a850 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. jest update

    @kt-12
    kt-12 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    f899c31 View commit details
    Browse the repository at this point in the history

  2. fix review changes.

    @kt-12
    kt-12 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    ff4376e View commit details
    Browse the repository at this point in the history

  3. fix jest

    @kt-12
    kt-12 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    f46e880 View commit details
    Browse the repository at this point in the history

  4. fix unused variable

    @kt-12
    kt-12 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    f0ab0f6 View commit details
    Browse the repository at this point in the history

  5. remove only

    @kt-12
    kt-12 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    9caf01d View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. fix jest

    @kt-12
    kt-12 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    5a27b75 View commit details
    Browse the repository at this point in the history

  2. remove unnecessary typecasting.

    @kt-12
    kt-12 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    f8c3339 View commit details
    Browse the repository at this point in the history

  3. css changes

    @kt-12
    kt-12 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    0e80569 View commit details
    Browse the repository at this point in the history

  4. div -> component

    @kt-12
    kt-12 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    64eaab6 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Style fixes

    @joemcgill
    joemcgill committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    b0c712e View commit details
    Browse the repository at this point in the history

  2. More style adjustments

    @joemcgill
    joemcgill committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    64eb3b4 View commit details
    Browse the repository at this point in the history

  3. add new Fulfill for ad report.

    @kt-12
    kt-12 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    d1fe9eb View commit details
    Browse the repository at this point in the history

  4. check for text content in Summary+ mock add empty campaign.

    @kt-12
    kt-12 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    c7bbc72 View commit details
    Browse the repository at this point in the history

  5. update variable name. 

    Co-authored-by: Eason <[email protected]>
    @kt-12 @eason9487
    kt-12 and eason9487 authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    0f809f3 View commit details
    Browse the repository at this point in the history

  6. remove margin 

    Co-authored-by: Eason <[email protected]>
    @kt-12 @eason9487
    kt-12 and eason9487 authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    c724767 View commit details
    Browse the repository at this point in the history

  7. remove size attribute. 

    Co-authored-by: Eason <[email protected]>
    @kt-12 @eason9487
    kt-12 and eason9487 authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    1a516c7 View commit details
    Browse the repository at this point in the history