-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Woo Navigation integration #2574
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2574 +/- ##
===========================================
+ Coverage 64.5% 64.6% +0.1%
+ Complexity 4591 4584 -7
===========================================
Files 796 793 -3
Lines 22992 22940 -52
Branches 1234 1231 -3
===========================================
- Hits 14837 14826 -11
+ Misses 7982 7941 -41
Partials 173 173
Flags with carried forward coverage won't be shown. Click here to find out more.
|
as we no longer need its offset to do calculations removed in #1206
Not to mention WC Navigation, but to preventively filter classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tomalec, thanks for updating all extensions!
- Ran smoke tests against this branch and all extension navigation is working as expected
- E2E tests are all passing
- Unable to find any remaining code referencing Woo Navigation
So the changes all look good to me ✅
Changes proposed in this Pull Request:
Remove all WooCommerce Navigation-related code, hacks and workarounds.
Closes #2406
Replace this with a good description of your changes & reasoning.
PRs that introduced some navigation-related code:
path
in URL to make additional pages work with WooCommerce Navigation #743As a bonus, I also removed CSS hacks needed for the
useWPBodyMarginOffsetEffect
removed in 28a8052
Screenshots:
Detailed test instructions:
This PR aims to remove eventually dead code and does not change any functionality.
So we need to check for regression if everything works as before with classic navigation.
/wp-admin/admin.php?page=wc-admin&path=%2Fgoogle%2Fsetup-mc
look with different window widths (watch out for the top gap)Marketing > Google for WooCommerce
is always highlighted for all G4W pagesAdditional details:
Changelog entry