Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Woo Navigation integration #2574

Merged
merged 9 commits into from
Sep 4, 2024
Merged

Remove Woo Navigation integration #2574

merged 9 commits into from
Sep 4, 2024

Conversation

tomalec
Copy link
Member

@tomalec tomalec commented Sep 2, 2024

Changes proposed in this Pull Request:

Remove all WooCommerce Navigation-related code, hacks and workarounds.

Closes #2406

Replace this with a good description of your changes & reasoning.

PRs that introduced some navigation-related code:

As a bonus, I also removed CSS hacks needed for the useWPBodyMarginOffsetEffect
removed in 28a8052

Screenshots:

Detailed test instructions:

This PR aims to remove eventually dead code and does not change any functionality.

So we need to check for regression if everything works as before with classic navigation.

  1. Run automated tests
  2. Smoke test everything :goberserk:
  3. Check the main Tab navigation
  4. Check Reports sub-navigation
  5. Check the layout for full-pages (setup Ads & MC) and full-content ( create/edit campaign, edit address & phone number) pages
  6. Check /wp-admin/admin.php?page=wc-admin&path=%2Fgoogle%2Fsetup-mc look with different window widths (watch out for the top gap)
  7. Check if the Marketing > Google for WooCommerce is always highlighted for all G4W pages
  8. Search the codebase looking for any code related to support WooCommerce Navigation.

Additional details:

Changelog entry

Break - Remove WooCommerce Navigation integration.

@tomalec tomalec changed the title Remove Woo Navigation Remove Woo Navigation integration Sep 2, 2024
@tomalec tomalec self-assigned this Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.

Project coverage is 64.6%. Comparing base (93b4180) to head (8731dee).
Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
src/Menu/Dashboard.php 0.0% 5 Missing ⚠️
src/Menu/GetStarted.php 0.0% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             develop   #2574     +/-   ##
===========================================
+ Coverage       64.5%   64.6%   +0.1%     
+ Complexity      4591    4584      -7     
===========================================
  Files            796     793      -3     
  Lines          22992   22940     -52     
  Branches        1234    1231      -3     
===========================================
- Hits           14837   14826     -11     
+ Misses          7982    7941     -41     
  Partials         173     173             
Flag Coverage Δ
js-unit-tests 62.7% <100.0%> (-0.1%) ⬇️
php-unit-tests 65.2% <0.0%> (+0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
js/src/attribute-mapping/index.js 100.0% <ø> (ø)
js/src/components/main-tab-nav/main-tab-nav.js 90.0% <100.0%> (ø)
js/src/dashboard/index.js 78.1% <ø> (ø)
js/src/hooks/useLayout.js 9.1% <ø> (ø)
js/src/hooks/useMenuEffect.js 100.0% <100.0%> (ø)
js/src/index.js 77.1% <100.0%> (-2.3%) ⬇️
js/src/product-feed/index.js 100.0% <ø> (ø)
src/Menu/Dashboard.php 0.0% <0.0%> (ø)
src/Menu/GetStarted.php 0.0% <0.0%> (ø)

@tomalec tomalec added the changelog: breaking A change breaking previous API or functionality. label Sep 2, 2024
@tomalec tomalec marked this pull request as ready for review September 2, 2024 18:20
@tomalec tomalec requested a review from a team September 2, 2024 19:35
Copy link
Contributor

@martynmjones martynmjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tomalec, thanks for updating all extensions!

  • Ran smoke tests against this branch and all extension navigation is working as expected
  • E2E tests are all passing
  • Unable to find any remaining code referencing Woo Navigation

So the changes all look good to me ✅

@tomalec tomalec merged commit 12c09f8 into develop Sep 4, 2024
15 checks passed
@tomalec tomalec deleted the remove/2406-woo-nav branch September 4, 2024 20:21
@martynmjones martynmjones mentioned this pull request Sep 5, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: breaking A change breaking previous API or functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the support for new WooCommerce Navigation
2 participants