Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align namespaces for unit tests #2561

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Align namespaces for unit tests #2561

merged 2 commits into from
Aug 26, 2024

Conversation

mikkamp
Copy link
Contributor

@mikkamp mikkamp commented Aug 23, 2024

Changes proposed in this Pull Request:

There were several copy and paste errors for the namespaces being used in Unit tests. Because there were no conflicts this isn't a big deal, but this PR ensures the correct namespace is being used for each test. I also removed some unused import lines.

Detailed test instructions:

  1. Install latest versions for unit testing bin/install-wp-tests.sh <db_name> <db_user> <db_pass>
  2. Run unit tests vendor/bin/phpunit
  3. Confirm that all tests continue to pass without issues

Changelog entry

  • Dev - Align namespaces for unit tests.

@mikkamp mikkamp self-assigned this Aug 23, 2024
@github-actions github-actions bot added the changelog: dev Developer-facing only change. label Aug 23, 2024
@mikkamp mikkamp requested a review from a team August 23, 2024 11:08
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.0%. Comparing base (ec86226) to head (30fa48f).
Report is 48 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             develop   #2561   +/-   ##
=========================================
  Coverage       65.0%   65.0%           
  Complexity      4588    4588           
=========================================
  Files            475     475           
  Lines          17900   17900           
=========================================
  Hits           11640   11640           
  Misses          6260    6260           
Flag Coverage Δ
php-unit-tests 65.0% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@martynmjones martynmjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mikkamp, thanks for keeping our tests clean!

All tests are passing locally and the namespace changes and deletions all look good to me ✅

@mikkamp mikkamp merged commit 4c96cd7 into develop Aug 26, 2024
14 checks passed
@mikkamp mikkamp deleted the dev/unit-test-namespaces branch August 26, 2024 15:08
@tomalec tomalec mentioned this pull request Aug 27, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: dev Developer-facing only change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants