Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.7.2 #2426

Merged
merged 233 commits into from
Jun 10, 2024
Merged

Release 2.7.2 #2426

merged 233 commits into from
Jun 10, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 10, 2024

Checklist

  1. Check if the version, base, and target branches are as you desire.
  2. Make sure you have woorelease installed and set up.
  3. Go to your local repo clone, and check out this PR to be able to commit any potential adjustments.
    git fetch origin release/2.7.2
    git checkout release/2.7.2
  4. Remove older changelog entries from readme.txt (keep the last two versions, since we will be adding a third during the release), commit changes.
  5. If there are new database migration classes (under src/DB/Migration/), modify their applicable version set in the get_applicable_version class of each migration class to be the same value as the version that is to be released.
    ⚠️ Notice that x.x.x is not a valid version and should be set manually with the new version. So, for example, if we are releasing version 1.12.0 and there is a file Migration20211228T1640692399.php inside src/DB/Migration/, you should open that file and in the method get_applicable_version return 1.12.0.
  6. ❗ If this release has updated composer packages, we should test Composer package conflicts with other plugins.
  7. Simulate the release locally
    woorelease simulate --product_version=2.7.2  --wc_tested=9.0 --generate_changelog https://github.com/woocommerce/google-listings-and-ads/tree/release/2.7.2
    Note: Select y when prompted: "Would you like to add/delete them in the svn working copy?"
  8. The changelog is correct.
    Check if some entries are missing, need rewording, or need to be deleted. You can edit respective PRs by changing their title, ### Changelog entry section, or assigning the changelog: none label.
    You can also edit the changelog manually in the woorelease release step later.
  9. Automated tests are passing.
  10. Test the package
    1. Install the /tmp/google-listings-and-ads.zip file on a test site
    2. Confirm it activates without warnings/errors and is showing the right versions
    3. Run a few basic smoke tests

Next steps

  1. Do the final release
    woorelease release --product_version=2.7.2  --wc_tested=9.0  --generate_changelog https://github.com/woocommerce/google-listings-and-ads/tree/release/2.7.2
    
    When prompted for changelog entries, double-check and apply any changes if needed.
  2. Go to https://github.com/woocommerce/google-listings-and-ads/releases/2.7.2, generate GitHub release notes, and paste them as a comment here.
  3. Merge this PR after the new release is successfully created and the version tags are updated.
  4. Merge trunk to develop (PR), if applicable for this repo.
  5. Update documentation
    • Publish any new required docs
    • Update triggers/rules/actions listing pages
  6. Mark related ideas complete on the feature requests page.

ankitrox and others added 30 commits January 12, 2024 18:45
Make merchant account non-required for ads account setup
…-step1-followup

Move useGoogleAccountCheck to its own file.
Update tests for conversion tracking without a merchant account
eason9487 and others added 20 commits May 31, 2024 10:58
…oid different hook entities affecting each other.

Address: #2419 (comment)
…st a callback argument to make its purpose clearer.

Address: #2419 (comment)
…art-1

Adjust event tracking for the creating and claim buttons of Google Ads account
…art-2

Adjust click event tracking when connecting, disconnecting, and opening billing setup for Google Ads account
…on-tracking

Enable users to seamlessly set up conversion tracking during the onboarding flow
Disallow tracking enabled check in the extension
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 76.24309% with 43 lines in your changes missing coverage. Please review.

Project coverage is 63.4%. Comparing base (1b7b1d5) to head (43af1f8).

Current head 43af1f8 differs from pull request most recent head 62cc942

Please upload reports for the commit 62cc942 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             trunk   #2426      +/-   ##
==========================================
- Coverage     64.2%   63.4%    -0.7%     
==========================================
  Files          755     321     -434     
  Lines        21538    5027   -16511     
  Branches      1157    1218      +61     
==========================================
- Hits         13818    3188   -10630     
+ Misses        7559    1672    -5887     
- Partials       161     167       +6     
Flag Coverage Δ
js-unit-tests 63.4% <76.2%> (+0.6%) ⬆️
php-unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
js/src/components/account-card/index.js 96.8% <ø> (ø)
...ts/google-ads-account-card/claim-account-button.js 100.0% <100.0%> (ø)
...nts/google-ads-account-card/claim-account/index.js 100.0% <100.0%> (ø)
...nents/google-ads-account-card/connect-ads/index.js 96.0% <100.0%> (ø)
...-account-card/connected-google-ads-account-card.js 0.0% <ø> (ø)
...s/google-ads-account-card/create-account-button.js 11.1% <100.0%> (ø)
...omponents/google-ads-account-card/disabled-card.js 100.0% <100.0%> (ø)
...ents/google-ads-account-card/disconnect-account.js 100.0% <100.0%> (ø)
...nents/google-ads-account-card/terms-modal/index.js 100.0% <100.0%> (ø)
...onents/paid-ads/billing-card/billing-setup-card.js 92.9% <100.0%> (+63.4%) ⬆️
... and 18 more

... and 469 files with indirect coverage changes

@mikkamp
Copy link
Contributor

mikkamp commented Jun 10, 2024

PHP Unit tests are currently failing because the script to fetch the latest WooCommerce versions, is fetching non existent tagged versions. WC 9.0 (among other things) is currently being prepared.

The unit tests are passing with the latest stable WC version: https://github.com/woocommerce/google-listings-and-ads/actions/runs/9449506820/job/26027407446?pr=2426
The E2E tests are also passing, so based on these two tests I'll proceed with the release.

@mikkamp
Copy link
Contributor

mikkamp commented Jun 10, 2024

Original changelog notes:

  • Add - Google Ads account invitation acceptance step to the connection process.
  • Fix - Show tracking snapshots in WPCLI.
  • Tweak - Adjust click event tracking when connecting, disconnecting, and opening billing setup for Google Ads account.
  • Tweak - Adjust event tracking for the creating and claim buttons of Google Ads account.
  • Tweak - WC 9.0 compatibility.
  • Update - Enable users to seamlessly set up conversion tracking, without having to set up merchant center first or requiring campaign creation.
  • Update - Move the Google Ads account connection process from step 4 to step 1 of the onboarding flow.

What's Changed

[Add] New Features 🎉

[Fix] Fixes 🛠

[Tweak] Tweaked 🔧

[Dev] Developer-facing changes 🧑‍💻

New Contributors

Full Changelog: 2.7.1...2.7.2

@mikkamp mikkamp merged commit 174c15e into trunk Jun 10, 2024
@mikkamp mikkamp deleted the release/2.7.2 branch June 10, 2024 14:26
@eason9487
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants