-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E tests: Onboarding Step 4 - Complete your campaign #2105
E2E tests: Onboarding Step 4 - Complete your campaign #2105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ianlin, the E2E tests are covering a lot of cases, thanks for all the work!
I've also added a comment regarding one test that I believe takes too long to run. The other comments I've left are about minor issues.
Thanks for reviewing @jorgemd24, I've addressed the comments you left and it's ready for anther round. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ianlin, LGTM! All tests are passing, and we've got a broad range of cases covered 👍
Changes proposed in this Pull Request:
Closes part of #2070, this PR adds E2E tests for 📌 Onboarding Step 4 - Complete your campaign.
Detailed test instructions:
npm run test:e2e -- tests/e2e/specs/setup-mc/step-4-complete-campaign.test.js
, the test should pass.npm run test:e2e-dev -- tests/e2e/specs/setup-mc/step-4-complete-campaign.test.js
, check the test in the chromium step by step.npm run test:e2e
to make sure all tests are passed.Additional information
This PR added 2 extra commits to:
await
for async actions in 2b0114cChangelog entry