Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E tests: Onboarding Step 4 - Complete your campaign #2105

Merged
merged 12 commits into from
Oct 2, 2023

Conversation

ianlin
Copy link
Member

@ianlin ianlin commented Sep 20, 2023

Changes proposed in this Pull Request:

Closes part of #2070, this PR adds E2E tests for 📌 Onboarding Step 4 - Complete your campaign.

Detailed test instructions:

  1. Follow these steps to set up the e2e env: https://github.com/woocommerce/google-listings-and-ads#e2e-testing
  2. Run npm run test:e2e -- tests/e2e/specs/setup-mc/step-4-complete-campaign.test.js, the test should pass.
  3. Or, run npm run test:e2e-dev -- tests/e2e/specs/setup-mc/step-4-complete-campaign.test.js, check the test in the chromium step by step.
  4. Run npm run test:e2e to make sure all tests are passed.

Additional information

This PR added 2 extra commits to:

  • fixed a failed test in onboarding step 1 in 8127446
  • added a missing await for async actions in 2b0114c

Changelog entry

Dev - E2E - Onboarding Step 4 - Complete your campaign

@ianlin ianlin requested a review from a team September 20, 2023 12:40
@ianlin ianlin self-assigned this Sep 20, 2023
@github-actions github-actions bot added the changelog: dev Developer-facing only change. label Sep 20, 2023
Copy link
Contributor

@jorgemd24 jorgemd24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ianlin, the E2E tests are covering a lot of cases, thanks for all the work!

I've also added a comment regarding one test that I believe takes too long to run. The other comments I've left are about minor issues.

tests/e2e/specs/setup-mc/step-4-complete-campaign.test.js Outdated Show resolved Hide resolved
tests/e2e/specs/setup-mc/step-4-complete-campaign.test.js Outdated Show resolved Hide resolved
tests/e2e/specs/setup-mc/step-4-complete-campaign.test.js Outdated Show resolved Hide resolved
tests/e2e/specs/setup-mc/step-4-complete-campaign.test.js Outdated Show resolved Hide resolved
tests/e2e/specs/setup-mc/step-4-complete-campaign.test.js Outdated Show resolved Hide resolved
@ianlin
Copy link
Member Author

ianlin commented Sep 28, 2023

Thanks for reviewing @jorgemd24, I've addressed the comments you left and it's ready for anther round.

Copy link
Contributor

@jorgemd24 jorgemd24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ianlin, LGTM! All tests are passing, and we've got a broad range of cases covered 👍

@ianlin ianlin merged commit 2c73378 into develop Oct 2, 2023
5 checks passed
@ianlin ianlin deleted the dev/2070-e2e-onboarding-step-4-complete-your-campaign branch October 2, 2023 03:17
@puntope puntope mentioned this pull request Oct 3, 2023
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: dev Developer-facing only change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants