Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undesired margin in Paid Campaign Creation Success modal #2093

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Fix undesired margin in Paid Campaign Creation Success modal #2093

merged 1 commit into from
Sep 14, 2023

Conversation

puntope
Copy link
Contributor

@puntope puntope commented Sep 13, 2023

Changes proposed in this Pull Request:

This PR fixes sa bug in Paid Campaign Creation Success Modal. An undesired margin was in the modal.

Screenshots:

Before:

Screenshot 2023-09-13 at 15 52 09

After:

Screenshot 2023-09-13 at 16 06 50

Detailed test instructions:

  1. Create a new PaidCampaign
  2. See that the modal looks like the "After" section in screenshots. .

Additional details:

Changelog entry

FIx - Undesired margin in Paid Campaign Creation Success Modal

@puntope puntope self-assigned this Sep 13, 2023
@puntope puntope requested a review from a team September 13, 2023 12:11
@github-actions github-actions bot added changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug. labels Sep 13, 2023
@puntope puntope marked this pull request as ready for review September 13, 2023 12:15
mikkamp
mikkamp approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@mikkamp mikkamp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, the changes look good to me. I no longer see the margin:

image

It also doesn't affect other modals with an adjusted header:
image

@puntope puntope merged commit 3735985 into develop Sep 14, 2023
5 checks passed
@puntope puntope deleted the fix/margin-campaign-creation-success-modal branch September 14, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkamp mikkamp mikkamp approved these changes

Assignees

@puntope puntope

Labels
changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puntope @mikkamp