Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Taxonomy Attribute Mapping for Product Variations #2074

Merged
merged 5 commits into from
Aug 29, 2023

Conversation

puntope
Copy link
Contributor

@puntope puntope commented Aug 28, 2023

Changes proposed in this Pull Request:

Closes #2071

  • Adjusts WCProductAdapter::get_product_taxonomy method to return Parent terms as a fallback for taxonomies like product_tag, product_cat etc...
  • Adding some tests covering this edge case

Detailed test instructions:

  1. Follow the use case in Product tags not working with Google attributes on variable products #2071 and see it solved.

Additional details:

Changelog entry

Fix - Fix Taxonomy Attribute Mapping for Product Variations.

@puntope puntope self-assigned this Aug 28, 2023
@puntope puntope requested a review from a team August 28, 2023 09:41
@github-actions github-actions bot added changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug. labels Aug 28, 2023
@puntope puntope marked this pull request as ready for review August 28, 2023 09:49
Copy link
Contributor

@martynmjones martynmjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @puntope, thanks for the quick fix 🙌

Tested locally and confirmed that the parent products terms will be used for variations as a fallback and the data successfully syncs with Merchant Center. So LGTM ✅

@puntope puntope merged commit 7812c76 into develop Aug 29, 2023
9 checks passed
@puntope puntope deleted the fix/attributes-taonomy-parent branch August 29, 2023 14:13
@eason9487 eason9487 changed the title Fix/attributes taonomy parent Fix Taxonomy Attribute Mapping for Product Variations Aug 30, 2023
@sukafia
Copy link

sukafia commented Sep 1, 2023

@eason9487 I see the fix is ready. Is there a timeframe for rolling out the update?

@eason9487
Copy link
Member

Hi @sukafia, I added this extension to the release schedule and expect to release it next Tuesday.

@puntope puntope mentioned this pull request Sep 5, 2023
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product tags not working with Google attributes on variable products
4 participants