Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trigger method in Hooks Generator Workflow #2073

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

puntope
Copy link
Contributor

@puntope puntope commented Aug 25, 2023

Changes proposed in this Pull Request:

This is a follow-up PR after a comment here woocommerce/woocommerce-google-analytics-integration#293 (comment) i

In brief, the workflow doesn't trigger correctly when woorlease creates the release branch.

This PR updates the trigger following the suggested and already approved way to trigger the workflow.

Now were trigger the workflow when changelog.txt is pushed, as this is the last commit woorelease does.

Detailed test instructions:

Checking the changes. We need to test it directly in the release after merge.

@github-actions github-actions bot added the changelog: dev Developer-facing only change. label Aug 25, 2023
@puntope puntope marked this pull request as ready for review August 25, 2023 12:48
@puntope puntope requested a review from a team August 25, 2023 12:48
@puntope puntope self-assigned this Aug 25, 2023
Copy link
Member

@eason9487 eason9487 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@puntope puntope merged commit d3192ea into develop Aug 28, 2023
3 checks passed
@puntope puntope deleted the dev/hook-generator-trigger-update branch August 28, 2023 06:41
@ianlin ianlin mentioned this pull request Aug 29, 2023
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: dev Developer-facing only change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants