-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply consistent admin theme colors to common UI components #2059
Conversation
… the Get Started page.
… in `Guide` component.
…and simplify its layout and style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @eason9487, thanks for improving the colours used throughout GLA 👍
Tested locally and following your testing instructions all relevant colours were updated to match the admin selection. There are two areas where the hard-coded colour is still coming through.
Unchecked requirements on the pre-launch list:
Both final URL icons on the Optimize your campaign screen:
Hi @martynmjones, thanks for the review.
Thanks for catching this! Fixed in fcb0dcd.
These two I didn't include because they are non-interactive icons and are paired with other colors in it or the background color where it is used. Could you help with a new round of code reviews? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two I didn't include because they are non-interactive icons and are paired with other colors in it or the background color where it is used.
That makes sense and thanks for the clarification 👍
Tested again and the issue with the pre-launch checklist has been fixed so LGTM ✅
Changes proposed in this Pull Request:
Closes #2058
This PR applies the admin theme colors for:
Guide
component.TopBar
component.In addition, this PR also simplifies the layout and style of
TopBar
component.💡 The color of native
<select>
won't be fixed in this PR as it's specified in WP core.Screenshots:
📷 Link color on the Get Started page
📷 Active dot in the page control
📷 Icon color when hovering
Detailed test instructions:
Locally change the value of
mcSupportedCountry
,mcSupportedLanguage
, andadsSetupComplete
tofalse
:google-listings-and-ads/src/Admin/Admin.php
Lines 130 to 133 in 2df2bd8
/wp-admin/profile.php
/wp-admin/admin.php?page=wc-admin&path=%2Fgoogle%2Fproduct-feed&guide=submission-success
:hover
colorTopBar
component layout is rendered as it was beforeChangelog entry