Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 2.5.2 #2049

Merged
merged 27 commits into from
Aug 8, 2023
Merged

release 2.5.2 #2049

merged 27 commits into from
Aug 8, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 8, 2023

Checklist

  1. Check if the version, base, and target branches are as you desire.
  2. Make sure you have woorelease installed and set up.
  3. Go to your local repo clone, and check out this PR to be able to commit any potential adjustments.
    git fetch origin release/2.5.2
    git checkout release/2.5.2
  4. Remove older changelog entries from readme.txt (keep the last two versions, since we will be adding a third during the release), commit changes.
  5. If there are new database migration classes (under src/DB/Migration/), modify their applicable version set in the get_applicable_version class of each migration class to be the same value as the version that is to be released.
    ⚠️ Notice that x.x.x is not a valid version and should be set manually with the new version. So, for example, if we are releasing version 1.12.0 and there is a file Migration20211228T1640692399.php inside src/DB/Migration/, you should open that file and in the method get_applicable_version return 1.12.0.
  6. ❗ If this release has updated composer packages, we should test Composer package conflicts with other plugins.
  7. Simulate the release locally
    woorelease simulate --product_version=2.5.2  --wp_tested=6.3 --wc_tested=8.0 --generate_changelog https://github.com/woocommerce/google-listings-and-ads/tree/release/2.5.2
    Note: Select y when prompted: "Would you like to add/delete them in the svn working copy?"
  8. The changelog is correct.
    Check if some entries are missing, need rewording, or need to be deleted. You can edit respective PRs by changing their title, ### Changelog entry section, or assigning the changelog: none label.
    You can also edit the changelog manually in the woorelease release step later.
  9. Automated tests are passing. - Only codecov fails
  10. Test the package
    1. Install the /tmp/google-listings-and-ads.zip file on a test site
    2. Confirm it activates without warnings/errors and is showing the right versions
    3. Run a few basic smoke tests

Next steps

  1. Do the final release
    woorelease release --product_version=2.5.2  --wp_tested=6.3 --wc_tested=8.0  --generate_changelog https://github.com/woocommerce/google-listings-and-ads/tree/release/2.5.2
    
    When prompted for changelog entries, double-check and apply any changes if needed.
  2. Go to https://github.com/woocommerce/google-listings-and-ads/releases/2.5.2, generate GitHub release notes, and paste them as a comment here.
  3. Merge this PR after the new release is successfully created and the version tags are updated.
  4. Merge trunk to develop (if applicable for this repo).

tomalec and others added 22 commits July 26, 2023 22:39
`woocommerce_admin_onboarding_task_list` is deprecated.
Fixes #2024

Remove `remove_woocommerce_extended_task_list_item` hook.
remove the need for `CompleteSetup` class
As that is what actually matters from the feature's behavior perspective.
WP 6.3 Compatibility: Fix the errors of "setImmediate is not defined"
…efresh-compatible

Make the gtag-events.js work with the Fast Refresh development mode
@jorgemd24 jorgemd24 self-assigned this Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #2049 (32b8d04) into trunk (fa2a652) will increase coverage by 0.1%.
The diff coverage is 36.5%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             trunk   #2049     +/-   ##
=========================================
+ Coverage     58.1%   58.2%   +0.1%     
+ Complexity    4128    4119      -9     
=========================================
  Files          456     454      -2     
  Lines        17723   17701     -22     
=========================================
  Hits         10297   10297             
+ Misses        7426    7404     -22     
Flag Coverage Δ
php-unit-tests 58.2% <36.5%> (+0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
google-listings-and-ads.php 6.4% <0.0%> (ø)
src/Admin/Admin.php 0.0% <0.0%> (ø)
src/Google/GlobalSiteTag.php 0.0% <0.0%> (ø)
...ernal/DependencyManagement/CoreServiceProvider.php 0.0% <0.0%> (ø)
src/TaskList/CompleteSetupTask.php 67.9% <67.9%> (ø)

@jorgemd24
Copy link
Contributor

Release 2.5.2

  • Fix - Remove add_woocommerce_extended_task_list_item and remove_woocommerce_extended_task_list_item hooks.
  • Fix - WordPress 6.3 compatibility: The forms and image selector may not work due to "setImmediate" deprecation.
  • Tweak - Use the latest API to add an item to the WC tasks list.
  • Tweak - WC 8.0 compatibility.
  • Tweak - WP 6.3 compatibility.

@jorgemd24 jorgemd24 merged commit 0c095a6 into trunk Aug 8, 2023
14 of 15 checks passed
@jorgemd24 jorgemd24 deleted the release/2.5.2 branch August 8, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants