Skip to content

Commit

Permalink
Merge branch 'update/2603-create-ads-account' into update/2605-edit-a…
Browse files Browse the repository at this point in the history
…ccounts
  • Loading branch information
joemcgill committed Nov 6, 2024
2 parents 442b478 + 01f1097 commit 7ded84d
Showing 1 changed file with 10 additions and 19 deletions.
29 changes: 10 additions & 19 deletions tests/e2e/specs/setup-mc/step-1-accounts.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -683,19 +683,6 @@ test.describe( 'Set up accounts', () => {
googleAccountCard.getByText( 'Google Ads ID: 12345' )
).toBeVisible();
} );

test( 'should see the conversion action notice', async () => {
const googleAccountCard =
setUpAccountsPage.getGoogleAccountCard();
await expect(
googleAccountCard.getByText(
'Google Ads conversion measurement has been set up for your store.',
{
exact: true,
}
)
).toBeVisible();
} );
} );
} );

Expand Down Expand Up @@ -736,17 +723,21 @@ test.describe( 'Set up accounts', () => {
await popupPage.waitForLoadState();
const url = popupPage.url();
expect( url ).toMatch( /^https:\/\/example\.com(\/|\?|$)/ );
await popupPage.close();
} );

test( 'should see the merchant center id once account has been claimed', async () => {
test( 'should see the accounts card connected', async () => {
await setUpAccountsPage.mockAdsStatusClaimed();
await setUpAccountsPage.mockAdsAccountConnected();

await setUpAccountsPage.goto();
await page.reload();

const googleAccountCard = setUpAccountsPage.getGoogleAccountCard();
await expect( googleAccountCard ).toContainText(
'Google Ads ID: 12345'
);

await expect(
googleAccountCard.getByText( 'Connected', {
exact: true,
} )
).toBeVisible();
} );
} );

Expand Down

0 comments on commit 7ded84d

Please sign in to comment.