-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reworking how pixel events on redirect to cart are handled. #2671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me broken after one of the fixes was introduced to fix cloned carts issue.
github-actions
bot
added
changelog: fix
Took care of something that wasn't working.
type: bug
The issue is a confirmed bug.
labels
Dec 10, 2023
rawdreeg
reviewed
Dec 11, 2023
budzanowski
reviewed
Dec 11, 2023
budzanowski
reviewed
Dec 11, 2023
budzanowski
reviewed
Dec 11, 2023
budzanowski
reviewed
Dec 11, 2023
budzanowski
reviewed
Dec 11, 2023
budzanowski
reviewed
Dec 11, 2023
Changing word Pinterest to Facebook. Co-authored-by: Rodrigue <[email protected]>
budzanowski
approved these changes
Dec 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one came from Slack channel.
When using Stripe plugin from one of 3rd party devs there was an issue with Facebook pixel events duplicated since that extension was cloning cart to perform some calculations which resulted in triggering cart hooks on a cloned object doubling the events.
After the fix from above was merged in another thing happened. The code added to prevent events from firing on cloned carts was failing when
redirect to cart after product added
setting is on. The reason to that is the previous fix was operating cart item key which was not always present when the code was called outsidewoocomerce_add_to_cart
hook.Current PR reworks the mechanism how events are rendered on
redirect to cart after product added
to make things work w/o any issues.Detailed test instructions:
Observe Meta Pixel Helper chrome extension looking for AddToCart events.
Go to WooCommerce Settings again and update them as on the screen below.
Additional details:
Changelog entry